Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format duration in TSV load complete Slack message #1648

Closed
1 task
stacimc opened this issue Feb 23, 2022 · 1 comment
Closed
1 task

Format duration in TSV load complete Slack message #1648

stacimc opened this issue Feb 23, 2022 · 1 comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly 🟩 priority: low Low priority and doesn't need to be rushed
Projects
Openverse

Comments

@stacimc
Copy link
Contributor

stacimc commented Feb 23, 2022

Problem

The TSV load-complete Slack notification (added in WordPress/openverse-catalog#369) reports the duration of the pull_data task with nanosecond precision. We don't need quite that much precision! 😄
Screen Shot 2022-02-23 at 3 28 24 PM

Description

This can be improved by removing some significant digits and formatting the elapsed time in a more readable format, with hours/minutes.

Alternatives

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@stacimc stacimc added good first issue New-contributor friendly 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Feb 23, 2022
@AetherUnbound
Copy link
Contributor

Closing in favor of #1649

@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly 🟩 priority: low Low priority and doesn't need to be rushed
Projects
Openverse Backlog
Archived in project
Openverse
  
Done!
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AetherUnbound @stacimc