Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Add reingestion workflow for Metropolitan #819

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Oct 22, 2022

Fixes

Fixes WordPress/openverse#1501 by @stacimc

Description

Screen Shot 2022-10-21 at 5 11 21 PM

Adds a reingestion workflow for Metropolitan.

Notes

  • For the configuration of reingestion days, I copied the configuration from Wikimedia. This is the existing configuration with the fewest number of nodes, so it feels like a reasonable first-attempt that can be reconfigured later.
  • The Metropolitan API has an 80 request per second rate limit. Historically, most DagRuns complete very quickly (<30 minutes), with a few outliers at ~5hrs and ~9.5hrs. I've set the initial max_active_tasks to 2, which should respect the rate limit while giving the DAG better odds of succeeding within 24 hours.

Testing Instructions

There is an edge case in the ingestion limit logic which causes Metropolitan to ignore limits, so make sure you have #818 locally if you want to set a LIMIT. You can also manually 'succeed' pull data tasks to get the workflow to move quicker.

Make sure the metropolitan_museum_reingestion_workflow looks as expected. Run it locally with a very small INGESTION_LIMIT (I used 10).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository labels Oct 22, 2022
@stacimc stacimc added this to In progress in Openverse PRs via automation Oct 22, 2022
@stacimc stacimc self-assigned this Oct 22, 2022
@stacimc stacimc requested a review from a team as a code owner October 22, 2022 00:20
@openverse-bot openverse-bot moved this from In progress to Needs review in Openverse PRs Oct 22, 2022
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I love how easy it is to add a new reingestion workflow 😄

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition process looks quite straightforward!

Openverse PRs automation moved this from Needs review to Reviewer approved Oct 25, 2022
@stacimc stacimc merged commit a9cdab5 into main Oct 25, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Oct 25, 2022
@stacimc stacimc deleted the add/reingestion-flow-for-metropolitan branch October 25, 2022 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

Create ingestion workflow for Metropolitan
3 participants