Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Restore the old dag_id for wikimedia_reingestion_workflow #837

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Oct 25, 2022

Fixes

Fixes #[issue number] by @[issue author]

Description

In a previous PR (#819) I updated the ProviderReingestionWorkflow to automatically generate the dag_id from the provider script filename, rather than explicitly defining it in each dataclass. Unfortunately I did not notice that Wikimedia's reingestion workflow was custom. It should be wikimedia_reingestion_workflow rather than the generated wikimedia_commons_reingestion_workflow. Since the DAG has a new id it is disabled and has no history in production.

We can fix this by restoring the old DAG id. Fortunately this is already supported by the dataclass.

Testing Instructions

just test

just up and verify that the DAG is named wikimedia_reingestion_workflow in your local env.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Oct 25, 2022
@stacimc stacimc self-assigned this Oct 25, 2022
@stacimc stacimc requested a review from a team as a code owner October 25, 2022 23:57
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Oct 25, 2022
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this shows up as wikimedia_reingestion_workflow, looks good!

Openverse PRs automation moved this from Needs review to Reviewer approved Oct 26, 2022
@stacimc stacimc merged commit 08b7fef into main Oct 26, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Oct 26, 2022
@stacimc stacimc deleted the fix/wikimedia-reingestion-dag-id branch October 26, 2022 19:37
@zackkrida zackkrida added this to Done! in Openverse Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
No open projects
Openverse
  
Done!
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants