This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Restore the old dag_id for wikimedia_reingestion_workflow #837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #[issue number] by @[issue author]
Description
In a previous PR (#819) I updated the
ProviderReingestionWorkflow
to automatically generate thedag_id
from the provider script filename, rather than explicitly defining it in each dataclass. Unfortunately I did not notice that Wikimedia's reingestion workflow was custom. It should bewikimedia_reingestion_workflow
rather than the generatedwikimedia_commons_reingestion_workflow
. Since the DAG has a new id it is disabled and has no history in production.We can fix this by restoring the old DAG id. Fortunately this is already supported by the dataclass.
Testing Instructions
just test
just up
and verify that the DAG is namedwikimedia_reingestion_workflow
in your local env.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin