Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Audit all the VLinks to make sure all have href and make it required #1840

Closed
1 task done
obulat opened this issue Sep 20, 2022 · 0 comments · Fixed by #1841
Closed
1 task done

Audit all the VLinks to make sure all have href and make it required #1840

obulat opened this issue Sep 20, 2022 · 0 comments · Fixed by #1841
Assignees
@obulat
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon

Comments

@obulat
Copy link
Contributor

obulat commented Sep 20, 2022 •
edited
Loading

Problem

Noted in #1829 (comment) : currently, the VLink component can sometimes not have an href prop and be rendered as a span.

Description

We should only use VLink when href is available, and remove the span fallback from VLink component.

Additional context

More discussion in #1829

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Sep 20, 2022
@obulat obulat self-assigned this Sep 20, 2022
@obulat obulat mentioned this issue Sep 20, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@obulat obulat

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove span from VLink WordPress/openverse-frontend
1 participant
@obulat