Use a non-versioned API URL to mock analytics requests, too

[obulat]

Fixes

Fixes #915 by @obulat

Description

This PR creates two ApiService objects: one is versioned, for most endpoints, and an unversioned one for the analytics endpoints.
Some data services were also refactored to reuse code from other services (getMediaSlug, for example), and the bug-report was removed as it is unused.
The proxy port was also changed from 3000 to 3322 because when I was testing, the API was running in Docker, and 3000 port was busy.
It also renames the update-tapes to recreate-tapes, and adds an update-tapes script that does not completely delete all the tapes, but simply adds any tapes that are missing. This way, we can update a single tape when any e2e test changes, and don't have too many changes in a PR.

Testing Instructions

Enable internal analytics:

openverse-frontend/src/utils/env.ts

Line 9 in 690f523

enableInternalAnalytics: process.env.ENABLE_INTERNAL_ANALYTICS ?? 'false',

Run pnpm run update-tapes. This will delete all the tapes files, and, more importantly, it will save any response that isn't found in test/tapes directory. You should see a lot of tapes for analytics responses. They are all 404, but they are there.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[sarayourfriend]

Is there any way to run talkback with the normal pnpm test:e2e script? Or is it only possible with the CI version?

Looking good so far, just testing locally but will probably be able to approve soon.

[sarayourfriend]

Doesn't this make recordMode always NEW? 🤔

[obulat]

This is also left-over from last-minute debugging :(

[sarayourfriend]

😅 This seems like a better choice considering how many other things live on port 3000 by default anyway (I know a few that are missing from this list too, like Flask I think?)

https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers

In fact, I kind of wonder if we shouldn't switch all of our stuff to use ports in the completely unregistered "temporary services" range of 49152–65535.

[obulat]

49152 it is, then :)

[sarayourfriend]

This LGTM. I noticed that in addition to #985 talkback also didn't stop running when I ran pnpm ci:e2e-test locally even though the tests passed and didn't crash or anything 😕 Did you notice that happening as well?

[sarayourfriend]

Oh I just noticed another tape was created when I ran pnpm ci:e2e-test locally.

[obulat]

Oh I just noticed another tape was created when I ran pnpm ci:e2e-test locally.

I just spent 15 minutes chasing these new tapes. There is often 1 image or audio request that's new. I think it's one of the related images or audio that sometimes change. I guess we should open an issue to mock related image / audio requests...

[sarayourfriend]

I just spent 15 minutes chasing these new tapes. There is often 1 image or audio request that's new. I think it's one of the related images or audio that sometimes change. I guess we should open an issue to mock related image / audio requests...

I think the fix I have in the proxy to replace API results that reference the upstream server with proxy references will address this, so I wouldn't sweat it.

[dhruvkb]

Works well, LGTM 👍