Handle waveform with peaks prop as a blank array

[dhruvkb]

Fixes

Fixes #1074 by @sarayourfriend

Description

This PR updates the peaks prop to use the default value even when given a truthy value of []. This prevents the peaks from showing up as blank.

Testing Instructions

0. Check out the PR and run the Storybook.
1. Visit a Waveform story and change the control for peaks to a blank array.
2. See the waveform become random.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[obulat]

Nice solution 👌

[sarayourfriend]

LGTM! I did like the suggestion you had before and am curious what your thought process was evaluating the trade offs between this solution and the other you suggested 🙂

[krysal]

Can some tests be included here? I noticed that the waveform component has none and it is important.

[zackkrida]

I'm okay with tests being added in a separate high-priority issue, in case we want to deploy this change this week or next.

[krysal]

There is no set date for a release the next week so I don't see a reason to rush here, as long as it is handled before the release as mentioned in the linked issue.

[dhruvkb]

I can add a couple of tests today and then merge it. Won't delay any releases!

[sarayourfriend]

I'm okay with tests being added in a separate high-priority issue, in case we want to deploy this change this week or next.

I don't think we can/should deploy this week anyway, it's Friday after all 🙂