Regenerate POT files if Vue files have been staged

[dhruvkb]

Fixes

Description

Since the PO files contain references to Vue components, this PR updates the code that generates them to run when Vue files are in the Git diff.

Testing Instructions

0. Make some line movements in Vue files.
1. Move and rename some Vue files.
2. Commit. Your last commit will also contain POT changes.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[sarayourfriend]

I don't love this solution because it forces you to commit all changes to the pot file regardless of whether you're commit all changes to all vue files that are changed.

For example, if you make changes to a.vue and b.vue but only stage b.vue, the line updates for a.vue will also be committed when you commit b.vue.

An alternative to this is to make this check a pre-push check to fail before running the unit tests if the POT file is out of date.

In any case, it's a pre-existing problem with the en.json file and theoretically the POT file having incorrect line numbers doesn't break the app's functionality so wouldn't inadvertently render an otherwise valid commit invalid (broken).

[dhruvkb]

In any case, we're not merging PRs till all reasonable checks pass so at the time of merge all differences between the POT and the Vue code will be resolved.

[obulat]

LGTM

[dhruvkb]

I just realised that this will still allow the POT check CI to fail. Need a more resilient approach here.

[sarayourfriend]

@dhruvkb Is there a problem with just always running the POT generation in pre-commit regardless of the files changed?

[dhruvkb]

The issue is that POT generation will include the changed but unstaged files unless those are staged before the commit.

[sarayourfriend]

@dhruvkb It did that for the original solution anyway, that's what my comment was about above.

We could move it to pre-push and encourage it to be a separate commit if that would make it clearer. What you said about the PR getting squashed before merge making the commit-level discrepancies irrelevant makes sense to me.

[dhruvkb]

This is not a good solution and still leaves room for CI failures.