This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add peaks=true to all audio searches #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1802 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
✨ goal: improvement
|
Size Change: -2.46 kB (0%) Total Size: 779 kB
ℹ️ View Unchanged
|
|
Thanks for the fix, @obulat! |
dhruvkb
approved these changes
Sep 12, 2022
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
obulat
approved these changes
Sep 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1800 by @krysal
Description
Wow, I struggled to work with the media services. I cannot wait to refactor some of that code.
Anyway, this PR adds a special case to add
peaks=trueto all audio and related audio searches. To do so I also had to upgrade the related media method to allow for query parameters. Maybe that will be a nice addition in the future.I'm not sure about tests here. Do we have any to verify the API endpoint paths are correct? Otherwise, this is covered by the fact that the visual regression tests would change if the peak data isn't downloaded. Still, it seems like we need better test coverage around the API endpoints in general.
Testing Instructions
Check on client-rendered searches that the
peaks=trueis present for all audio API search requests, and on related audio searches. Finally, make sure you see the same peaks on SSR searches.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin