This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix filters spacing with a new header #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the top and bottom margins should be 32px
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1938 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: -6.11 kB (-1%) Total Size: 810 kB
ℹ️ View Unchanged
|
obulat
added
🛠 goal: fix
obulat
changed the title
obulat
added
🟧 priority: high
dhruvkb
approved these changes
Oct 27, 2022
|
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @zackkrida Excluding weekend1 days, this PR was updated 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes |
krysal
reviewed
Nov 7, 2022
I got an email notification with the video, then checked out the branch to check how that could have happened, and then realized that the single result is not supposed to have a filters sidebar :) Thank you for reminding me about the tests, @krysal! I've added the snapshots of the sidebars. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #1581 by @panchovm
Description
This PR is a companion to #1931. It adds the correct padding values for the filters sidebar on
new_headerlayouts. It fixes the lack of padding on the desktop screens:Also, the unnecessary padding and margins are removed. To make sure that 'Clear filters' button doesn't affect the layout when it is shown or hidden, the button uses
absolutepositioning.Testing Instructions
Go to https://localhost:8443/preferences and make sure the New header flag is checked. Go to a search page and open the filters sidebar. It should have correct padding, and the layout should not change when 'Clear filters' button appears/disappears.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin