Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New styles in Audio control component #2602

Closed
fcoveram opened this issue Jul 10, 2023 · 3 comments · Fixed by #2929
Closed

New styles in Audio control component #2602

fcoveram opened this issue Jul 10, 2023 · 3 comments · Fixed by #2929
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@fcoveram
Copy link
Contributor

Description

As part of design changes introduced in #2113, the Audio control component in Design Library has new styles.

New audio control component with its variants and descriptive texts
  • Small size is removed due to its lack of use.
  • Tiny is renamed as Small.
  • Extra large is renamed as Large.
  • New sizes for each variant
    • Small: 32px, w-8 h-8
    • Medium: 48px, w-12 h-12
    • Large: 64px, w-16 h-16
  • New icon sizes for each variant
    • Small: 24px, w-6 h-6
    • Medium: 32px, w-8 h-8
    • Large: 40px, w-10 h-10
  • Hover and Focus styles follow the Button style
  • Default style has 2px for border radius, although this changes depending on the component context.

Context

The new styles are based on #415 implementation

Figma

Component in Design Library.

@fcoveram fcoveram added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: frontend Related to the Nuxt frontend and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 10, 2023
@obulat obulat self-assigned this Jul 11, 2023
@obulat obulat added ⛔ status: blocked Blocked & therefore, not ready for work design: needed Needs a designer's touch before implementation can begin labels Jul 18, 2023
@obulat
Copy link
Contributor

obulat commented Jul 18, 2023

This issue is blocked because the design for single result page for Audio also needs to be updated to match the new Audio control component sizes.

@fcoveram
Copy link
Contributor Author

fcoveram commented Jul 18, 2023

I'm confused about the blocking reason. The audio single result page was updated in the design file with this new audio control in both Full medium and Full small audio track components inserted in the page.

What I understood from the chat we had @obulat, is that this request creates unintended changes in the following components:

  • Row (large, medium, and small)
  • Box (large, and medium)
  • Global

Therefore, to unblock this request, I need to share an updated version of those audio components by including the audio control requested in this ticket.

Please correct me if I'm wrong.

@obulat
Copy link
Contributor

obulat commented Jul 18, 2023

Sorry, @fcoveram! I was wrong. Your list of what needs to be updated is right:

What I understood from the chat we had https://github.com/obulat, is that this request creates unintended changes in the following components:

Row (large, medium, and small)
Box (large, and medium)
Global

@sarayourfriend sarayourfriend assigned fcoveram and unassigned fcoveram Jul 24, 2023
@obulat obulat mentioned this issue Jul 26, 2023
8 tasks
@obulat obulat assigned fcoveram and unassigned obulat Aug 2, 2023
@obulat obulat added design: ready Issue with a mockup ready for implementation and removed ⛔ status: blocked Blocked & therefore, not ready for work design: needed Needs a designer's touch before implementation can begin labels Aug 31, 2023
@obulat obulat assigned obulat and unassigned fcoveram Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants