Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio components improvement #2910

Closed
fcoveram opened this issue Aug 28, 2023 · 3 comments · Fixed by #3297
Closed

Audio components improvement #2910

fcoveram opened this issue Aug 28, 2023 · 3 comments · Fixed by #3297
Assignees
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🖼️ aspect: design Concerns related to design design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@fcoveram
Copy link
Contributor

Problem

From the audio control update requested in #2602, the following components need to be updated to incorporate the button in a clean way.

  • Box (large, and medium)
  • Row (large, medium, and small)
  • Global

Proposal

All components and their variants mentioned above have new spacing, size, and style values. Before diving into each, here is a set of all pages involved in the component update.

Search results. All content

All content search results in all breakpoints

Search results. Audio

Audio search results in all breakpoints

Single result page

Single result page mockups in all breakpoints

Components

Audio box

The new box audio component has the following main changes:

  • The component was reduced to two variants: Large and Small. The medium size was not needed for Figma mockups.
  • The audio control is size: small .
  • Both large and small variants allow users to control the audio with the current play, pause, and repeat actions.
  • Only large variant shows the wave area.
  • All texts styles were updated to be consistent with other library changes.
Small Large
Small variant of audio box Large variant of audio box

Audio row

For the main audio component, the following changes were applied:

Size: Large

  • The current variant named “Medium” is now “Large”. This change comes from the variant used per breakpoint.
  • The audio control is size: large.
  • Cover image is now 64px to match the audio control button
  • All texts styles were updated to be consistent with other library changes.
  • Spacings in the audio text info were updated.

Large variant of audio row component

Size: Medium

  • The current variant named “Large” is now “Medium”. This change comes from the variant used per breakpoint.
  • The audio control is size: medium.
  • Cover image is the height formed by the sum of text info and wave area. In Figma it was set as 95px, but this should be revisited in code to meet a visual balance.
  • All texts styles were updated to be consistent with other library changes.
  • Spacings in the audio text info were updated.
Medium variant of audio row component

Size: Small

  • The current variant named “Large” is now “Medium”. This change comes from the variant used per breakpoint.
  • The audio control is size: medium.
  • Audio control is now placed in the left-bottom area to be consistent with the Audio box action.
  • Cover image is the height formed by the sum of text info and wave area. In Figma it was set as 95px, but this should be revisited in code to meet a visual balance.
  • All texts styles were updated to be consistent with other library changes.
  • Spacings in the audio text info were updated.
Small variant of audio row component

Global player

  • Cover image is now 48px to meet other library changes.
  • The audio control is size: medium.
  • There is a new style for the component border.
  • In page context, the component has a new position to prevent the blending effect with the browser area. See the mockups shared above.
  • There is a new style for long audio titles.
  • The current style for playing changed to solve interaction issues.
Global player component

Mockups

Figma file: Audio components improvement

@fcoveram fcoveram added 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature ♿️ aspect: a11y Concerns related to the project's accessibility 🖼️ aspect: design Concerns related to design 🧱 stack: frontend Related to the Nuxt frontend design: in discussion Issue has a design that needs feedback labels Aug 28, 2023
@openverse-bot
Copy link
Collaborator

Subscribe to Label Action

cc @WordPress/gutenberg-design, @WordPress/openverse

This issue or pull request has been labeled: "🖼️ aspect: design"

Thus the following users have been cc'd because of the following labels:

  • WordPress/gutenberg-design: 🖼️ aspect: design
  • WordPress/openverse: 🖼️ aspect: design

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@fcoveram
Copy link
Contributor Author

Labeling with high priority as it is blocking #2602

@fcoveram
Copy link
Contributor Author

In addition to the new styles described above for the global player, here I show three interaction changes that keep the current core idea.

Closing the component

Closing the component is an VIconButton in size: small / style: transparent / color: gray.

Audio global player. Closing interaction

Seeking audio time

The time-seeking interaction is now only in the wave area. The current player uses the whole yellow area to interact with time but it impedes going to the audio details page.

Audio global player. Seeking time

Going to audio single page

In line with the previous point, audio title is now a link to its single result page. In hover the link is underlined, like a regular link.

Audio global player. Hover interaction of audio title

Component background color

Finally, reinforce that the component background is white. This fixes a style missed in the initial design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🖼️ aspect: design Concerns related to design design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
3 participants