Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual regression tests for the sensitive content explanation page #3081

Closed
dhruvkb opened this issue Sep 29, 2023 · 3 comments · Fixed by #3179
Closed

Add visual regression tests for the sensitive content explanation page #3081

dhruvkb opened this issue Sep 29, 2023 · 3 comments · Fixed by #3179
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Sep 29, 2023

Problem

PR #3074 (fixing #2550) adds a page explaining our content safety approach. This page does not have visual regression tests because the translation for this page is nuanced and Google Translate would not be sufficient for this.

Description

We will wait for this page to be translated, and then use the official translations to add the VR tests for this page.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Sep 29, 2023
@dhruvkb dhruvkb added the ⛔ status: blocked Blocked & therefore, not ready for work label Sep 29, 2023
@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 29, 2023

This issue is blocked on the rollout of this page and subsequently on completion of official translations of this page into AR, ES and RU.

@obulat
Copy link
Contributor

obulat commented Oct 10, 2023

@dhruvkb, I used google translate to add the ar locale to tests, and I think we can use machine translated strings for testing.

@dhruvkb
Copy link
Member Author

dhruvkb commented Oct 10, 2023

Since the page has some sensitive text, I wanted to use the proper translations even in testing because I don't think Google Translate can capture the nuance of the wordings. We discussed this internally and the consensus was to wait for the page to be translated before adding VR tests.

@dhruvkb dhruvkb self-assigned this Oct 10, 2023
@dhruvkb dhruvkb removed the ⛔ status: blocked Blocked & therefore, not ready for work label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants