Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the page for sensitive content explanation #3074

Merged
merged 7 commits into from
Oct 5, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 28, 2023

Fixes

Fixes #2550 by @dhruvkb

Description

This PR adds the page for explanation about sensitive content and our filtering techniques.

Testing Instructions

  1. Check out the PR and run the dev server.
  2. Visit the page directly at /sensitive-content.
  3. Go to /preferences and turn on sensitive_content and fake_sensitive flags.
  4. Make a search query.
  5. Find a blurred result, click to open it.
  6. Click the link to "Learn more". You should be taken to the /sensitive-content page again.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Sep 28, 2023
@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 📄 aspect: text Concerns the textual material in the repository labels Sep 28, 2023
@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Size Change: +40.1 kB (+4%)

Total Size: 932 kB

Filename Size Change
./frontend/.nuxt/dist/client/239.js 0 B -343 B (removed) 🏆
./frontend/.nuxt/dist/client/239.modern.js 0 B -346 B (removed) 🏆
./frontend/.nuxt/dist/client/240.js 343 B -1.51 kB (-81%) 🏆
./frontend/.nuxt/dist/client/app.js 124 kB +905 B (+1%)
./frontend/.nuxt/dist/client/app.modern.js 115 kB +914 B (+1%)
./frontend/.nuxt/dist/client/commons/app.js 90 kB +15 B (0%)
./frontend/.nuxt/dist/client/commons/app.modern.js 81 kB +25 B (0%)
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/98a81936.js 0 B -5.18 kB (removed) 🏆
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/98a81936.modern.js 0 B -5.62 kB (removed) 🏆
./frontend/.nuxt/dist/client/components/v-error-section.js 5.2 kB -10 B (0%)
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.47 kB -44 B (-1%)
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.35 kB -50 B (-1%)
./frontend/.nuxt/dist/client/components/v-media-details.js 5.64 kB +3.01 kB (+115%) 🆘
./frontend/.nuxt/dist/client/components/v-media-details.modern.js 5.49 kB +2.89 kB (+111%) 🆘
./frontend/.nuxt/dist/client/components/v-media-details/pages/image/_id/index.js 0 B -3.79 kB (removed) 🏆
./frontend/.nuxt/dist/client/components/v-media-details/pages/image/_id/index.modern.js 0 B -3.67 kB (removed) 🏆
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 17.3 kB +6.53 kB (+61%) 🆘
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 16.2 kB +5.75 kB (+55%) 🆘
./frontend/.nuxt/dist/client/pages/image/_id/index.js 15.6 kB +5.88 kB (+61%) 🆘
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 14.6 kB +5.12 kB (+54%) 🆘
./frontend/.nuxt/dist/client/pages/search.js 5.78 kB +1 kB (+21%) 🚨
./frontend/.nuxt/dist/client/pages/search.modern.js 8.13 kB +3.57 kB (+78%) 🆘
./frontend/.nuxt/dist/client/runtime.js 2.79 kB +10 B (0%)
./frontend/.nuxt/dist/client/vendors/app.modern.js 68.1 kB +114 B (0%)
./frontend/.nuxt/dist/client/240.modern.js 346 B +346 B (new file) 🆕
./frontend/.nuxt/dist/client/241.js 1.85 kB +1.85 kB (new file) 🆕
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/e4094511.js 5.18 kB +5.18 kB (new file) 🆕
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/e4094511.modern.js 5.62 kB +5.62 kB (new file) 🆕
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.js 4.49 kB +4.49 kB (new file) 🆕
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.modern.js 4.38 kB +4.38 kB (new file) 🆕
./frontend/.nuxt/dist/client/pages/sensitive-content.js 1.52 kB +1.52 kB (new file) 🆕
./frontend/.nuxt/dist/client/pages/sensitive-content.modern.js 1.53 kB +1.53 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/components/loading-icon.js 730 B +1 B (0%)
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 735 B +1 B (0%)
./frontend/.nuxt/dist/client/components/table-sort-icon.js 515 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 518 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.78 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 6.61 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-collection.js 4.5 kB -8 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js 4.38 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-control.js 1.5 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-control.modern.js 1.5 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-list.js 1.44 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-list.modern.js 1.42 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-result.js 1.11 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-result.modern.js 1.1 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 959 B +2 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 961 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.7 kB +8 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.66 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 636 B 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 643 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.js 632 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 636 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.35 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.35 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-collection-header.js 1.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-collection-header.modern.js 1.31 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-content-link.js 1.07 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.06 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-content-page.js 530 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 534 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 492 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 496 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.33 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.21 kB -4 B (0%)
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.79 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.67 kB -8 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-button.js 4 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.34 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.31 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 795 B 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 799 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.51 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.47 kB +4 B (0%)
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 4.57 kB -6 B (0%)
./frontend/.nuxt/dist/client/components/v-external-search-form.js 4.1 kB -4 B (0%)
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 3.43 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-external-source-list.js 2.63 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 1.99 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.57 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.57 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.53 kB -7 B (0%)
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.53 kB -6 B (0%)
./frontend/.nuxt/dist/client/components/v-hide-button.js 577 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-hide-button.modern.js 573 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.28 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.26 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.82 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.79 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-image-cell.js 2.21 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 2.19 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 642 B 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 649 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-load-more.js 1.18 kB 0 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-license.js 931 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 940 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-reuse.js 3 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.97 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 420 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tags.js 589 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-tags.modern.js 588 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata-value.js 587 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata-value.modern.js 593 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata.js 1.3 kB 0 B
./frontend/.nuxt/dist/client/components/v-metadata.modern.js 1.31 kB +4 B (0%)
./frontend/.nuxt/dist/client/components/v-modal.js 980 B -2 B (0%)
./frontend/.nuxt/dist/client/components/v-modal.modern.js 973 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.js 2.67 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 2.03 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.01 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-related-audio.js 824 B 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 741 B 0 B
./frontend/.nuxt/dist/client/components/v-related-images.js 805 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 719 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 980 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.72 kB 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.72 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-safety-wall.js 1.44 kB 0 B
./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js 1.44 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 617 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 620 B -3 B (0%)
./frontend/.nuxt/dist/client/components/v-single-result-controls.js 1.17 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js 1.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.02 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 916 B 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.07 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.07 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-sources-table.js 14.7 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 14.7 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.42 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/about.modern.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.js 1.36 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.36 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/report.js 4.96 kB +3 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.73 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/index.js 6.38 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/index.modern.js 6.35 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.js 1.46 kB 0 B
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.46 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/privacy.js 1.26 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.js 1.62 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.61 kB 0 B
./frontend/.nuxt/dist/client/pages/search/audio.js 502 B 0 B
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 507 B 0 B
./frontend/.nuxt/dist/client/pages/search/image.js 460 B 0 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 462 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.js 316 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 319 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/model-3d.js 242 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B 0 B
./frontend/.nuxt/dist/client/pages/sources.js 1.54 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.54 kB +1 B (0%)
./frontend/.nuxt/dist/client/runtime.modern.js 2.79 kB +8 B (0%)
./frontend/.nuxt/dist/client/vendors/app.js 68.3 kB +1 B (0%)

compressed-size-action

@dhruvkb dhruvkb marked this pull request as ready for review September 29, 2023 09:19
@dhruvkb dhruvkb requested a review from a team as a code owner September 29, 2023 09:19
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good! I have one note about a TODO, and also, I noticed that the "sensitive" link in the Safe Browsing section of the search results page links to /about, should that link to /sensitive-content now?
Screenshot_2023-09-29_17-08-56

Comment on lines 26 to 29
<!-- TODO
<h2 id="on-off">{{ $t("sensitive.onOff.title") }}</h2>
<p>{{ $t("sensitive.onOff.description", { openverse: "Openverse" }) }}</p>
-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this still be TODO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this as TODO as this is a TODO in the reference Google doc. Alternatively I can write it directly in the PR and we can iterate on it here?

@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 30, 2023

Good catch @AetherUnbound, thank you! Updated the link in e4be495.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page works well!
The request for change is to change the title of the page from "about" to "sensitive content": the component's name property and the title in useMeta.

frontend/src/pages/sensitive-content.vue Outdated Show resolved Hide resolved
Co-authored-by: Olga Bulat <obulat@gmail.com>
@dhruvkb dhruvkb requested a review from obulat October 5, 2023 04:30
frontend/src/pages/sensitive-content.vue Outdated Show resolved Hide resolved
@dhruvkb dhruvkb merged commit c47c8d9 into main Oct 5, 2023
41 checks passed
@dhruvkb dhruvkb deleted the sensitive_content_page branch October 5, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a page explaining the sensitive content filtering approaches
4 participants