Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: Differences in strings between singular / plural: ending / not ending on period #3377

Closed
Presskopp opened this issue Nov 20, 2023 · 4 comments · Fixed by #3462
Closed
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@Presskopp
Copy link

Description

Singular ending on period, plural not here:

###count### image provided by this source. <> ###count### images provided by this source
###count### audio file with the selected tag. <> ###count### audio files with the selected tag
###count### image with the selected tag. <> ###count### images with the selected tag

compare:
Menu. ###count### filter applied

@Presskopp Presskopp added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels Nov 20, 2023
@krysal krysal added good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 📄 aspect: text Concerns the textual material in the repository 🧱 stack: frontend Related to the Nuxt frontend and removed 🛠 goal: fix Bug fix 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 20, 2023
@dhruvkb
Copy link
Member

dhruvkb commented Nov 27, 2023

Adding more context for someone solving the isssue. The fullstop must be removed from these particular strings in en.json5.

count: "{count} audio file provided by this source.|{count} audio files provided by this source",

count: "{count} image provided by this source.|{count} images provided by this source",

count: "{count} audio file with the selected tag.|{count} audio files with the selected tag",

count: "{count} image with the selected tag.|{count} images with the selected tag",

@roman-HS
Copy link

Is this still open? I would like to contribute. Can you please elaborate on the actual scope of the task?

@obulat
Copy link
Contributor

obulat commented Nov 29, 2023

@roman-HS, you will need to fork the repository, create a new branch and make the changes to the lines mentioned in the message above.
You will need to add a period (.) to the end of the second sentence in each line.
Edited to reflect @dhruvkb's comment below:
You will need to remove a period (.) from the end of the first phrase in each line.

@dhruvkb
Copy link
Member

dhruvkb commented Nov 29, 2023

@obulat to the contrary, these are not sentences, but rather phrases, so removing the existing periods would be more correct imo. As an non-authoritative example, we can refer to Google.

Screenshot 2023-11-29 at 9 47 22 AM

@obulat obulat added the 🟧 priority: high Stalls work on the project or its dependents label Dec 5, 2023
@obulat obulat removed the 🟨 priority: medium Not blocking but should be addressed soon label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants