Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make punctuation marks consistent for singular & plural strings #3462

Merged
merged 5 commits into from Dec 5, 2023

Conversation

NekoJonez
Copy link
Contributor

@NekoJonez NekoJonez commented Dec 5, 2023

Fixes

Fixes #3377 by @Presskopp

Description

This would solve #3377. Small simple fix.

@NekoJonez NekoJonez requested a review from a team as a code owner December 5, 2023 15:18
dhruvkb

This comment was marked as outdated.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvkb has shown some examples in the issue of similar phrases that do not use periods. Let's remove them from both variants, instead of adding, @NekoJonez ?

frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved
frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved
frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved
frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 📄 aspect: text Concerns the textual material in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Dec 5, 2023
@dhruvkb dhruvkb merged commit d13cde6 into WordPress:main Dec 5, 2023
42 checks passed
@dhruvkb dhruvkb changed the title Adding ending punctional marks Make punctuation marks consistent for singular & plural strings Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation: Differences in strings between singular / plural: ending / not ending on period
3 participants