Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @nuxtjs/svg .svg?inline components with native svgs #517

Closed
1 task
obulat opened this issue Aug 22, 2022 · 1 comment
Closed
1 task

Replace @nuxtjs/svg .svg?inline components with native svgs #517

obulat opened this issue Aug 22, 2022 · 1 comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects

Comments

@obulat
Copy link
Contributor

obulat commented Aug 22, 2022

Problem

@nuxtjs/svg provides a convenient way of creating a component out of any SVG file. However, the components it creates raise TS errors. The module also does not support Vite/Nuxt3.

Description

We should replace the inline components with SVG elements.

Alternatives

Keep using the inline components. That would require fixing types (using the docs from https://github.com/damianstasik/vue-svg-loader/blob/4c41b89246fa366c3214ebd56b183645b0e732e5/docs/faq.md#how-to-use-this-loader-with-typescript) and adding Vite/Nuxt3 support to the module in the future.

Additional context

First raised in WordPress/openverse-frontend#1350

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Aug 22, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@obulat
Copy link
Contributor Author

obulat commented Aug 10, 2023

Fixed in #2135 and #1808

@obulat obulat closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Openverse
  
Backlog
Development

No branches or pull requests

1 participant