Replace nuxtjs/svg with nuxtjs/svg-sprite
#2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧱 stack: documentation
|
Size Change: -9.43 kB (-1%) Total Size: 839 kB
ℹ️ View Unchanged
|
|
Full-stack documentation: https://docs.openverse.org/_preview/2135 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
8 tasks
obulat
force-pushed
the
remove/module_@nuxtjs/svg
branch
from
0241fd5
to
66e117e
Compare
obulat
force-pushed
the
fix/header_home_link
branch
from
5c966c1
to
a7982c5
Compare
obulat
force-pushed
the
remove/module_@nuxtjs/svg
branch
from
66e117e
to
64bf705
Compare
obulat
added
🟨 priority: medium
github-actions
bot
added
the
🧱 stack: documentation
obulat
force-pushed
the
fix/header_home_link
branch
2 times, most recently
from
e87d12f
to
ca6191e
Compare
obulat
force-pushed
the
remove/module_@nuxtjs/svg
branch
from
299fb93
to
dd84531
Compare
obulat
force-pushed
the
fix/header_home_link
branch
3 times, most recently
from
5a0ec34
to
375c672
Compare
obulat
force-pushed
the
remove/module_@nuxtjs/svg
branch
from
dd84531
to
fc4e441
Compare
obulat
force-pushed
the
remove/module_@nuxtjs/svg
branch
2 times, most recently
from
27b08a0
to
aeba68b
Compare
obulat
force-pushed
the
remove/module_@nuxtjs/svg
branch
2 times, most recently
from
99f4c1d
to
5e102b7
Compare
| aria-hidden="true" | ||
| focusable="false" | ||
| > | ||
| <use :href="`${Oops}#oops`" /> |
There was a problem hiding this comment.
Should this href have been deleted?
There was a problem hiding this comment.
Yes, the <VSvg> component handles finding the hrefs now, and we do not use the id of the inner SVG path. We only need to pass the name of the file to use it as an SVG.
AetherUnbound
approved these changes
May 26, 2023
obulat
commented
May 27, 2023
obulat
force-pushed
the
remove/module_@nuxtjs/svg
branch
from
21e2665
to
24b8d1a
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1849 by @obulat
Description
This PR replaces "nuxtjs/svg" library that does not have support for Nuxt 3 with "nuxtjs/svg-sprite". We already use it for icons.
To use it for the images of various sizes, we have to add a
viewBoxto theVSvgcomponents - I couldn't find a better solution, unfortunately.Testing Instructions
All of the Visual Regression tests in the CI should still pass because there should be no visible change.
So, to test this PR you would need to just read through the code and check that the CI passes.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin