Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Configure ESLint and Prettier for JS scripts #73

Closed
1 task
dhruvkb opened this issue Sep 21, 2021 · 1 comment
Closed
1 task

[Feature] Configure ESLint and Prettier for JS scripts #73

dhruvkb opened this issue Sep 21, 2021 · 1 comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects
Openverse

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Sep 21, 2021 •
edited

Problem

The JS scripts in the repo, located in js/ follow an arbitrary code style that's unrelated to the Openverse frontend repo.

Description

These JS scripts don't have linters, formatters and Git hooks configured. This should be set up in order to match the code style used in openverse-frontend.

Implementation

  • 🙋 I would be interested in implementing this feature.
@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 🤖 aspect: dx Concerns developers' experience with the codebase labels Sep 21, 2021
@dhruvkb dhruvkb added this to Backlog in Openverse Sep 21, 2021
@urakymzhan urakymzhan mentioned this issue Oct 8, 2021
Merged
7 tasks
@zackkrida
Copy link
Member

Completed in #90

Openverse automation moved this from Backlog to Done! Mar 23, 2022
dhruvkb pushed a commit that referenced this issue Feb 20, 2023
@zackkrida
Merge pull request #73 from WordPress/feedback
e3772e8
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@zackkrida
Merge pull request #73 from WordPress/release_drafter
1886fb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse
  
Done!
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zackkrida @dhruvkb