Update Back to results button to use the new VButton variant and size #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -72 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
|
Full-stack documentation: https://docs.openverse.org/_preview/1141 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
added
🟨 priority: medium
obulat
force-pushed
the
update/back_to_search
branch
from
bf0e196
to
3d7e369
Compare
6 tasks
obulat
force-pushed
the
update/back_to_search
branch
from
3d7e369
to
5cdd0df
Compare
obulat
force-pushed
the
update/back_to_search
branch
2 times, most recently
from
e8d7073
to
cd15b68
Compare
obulat
force-pushed
the
update/back_to_search
branch
5 times, most recently
from
1e67a0e
to
1128095
Compare
obulat
force-pushed
the
update/back_to_search
branch
from
1128095
to
1af143d
Compare
sarayourfriend
approved these changes
May 2, 2023
There was a problem hiding this comment.
LGTM with one caveat: on my local machine the button's focus border is slightly thinner on the bottom and right-hand sides. That might just be an issue with my screen resolution + zoom configuration (though I'm at 100% in the screenshot):
There's no snapshot test for the button in implementation so I can't confirm if Playwright sees the same issue, but as long @obulat you and the other reviewer don't see it, it's good to go for me.
Interesting. I rebased this PR onto main after merging #1118, and tried this in Chrome, Firefox and Safari, and couldn't replicate this issue. I wonder if all focus rings for transparent buttons look like that for you. Could you try the Storybook buttons? |
obulat
force-pushed
the
update/back_to_search
branch
from
9bfea0d
to
bf10b21
Compare
obulat
force-pushed
the
update/back_to_search
branch
from
bf10b21
to
df57f27
Compare
fcoveram
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #1020 by @obulat
Description
This PR updates the "Back to results" button to use a
transparent-graybutton in sizemedium.Testing Instructions
Check that the button looks correct.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin