Avoid the need to specify each image individually in `load-img` #1855

dhruvkb · 2023-04-20T16:47:15Z

Fixes

Fixes #1854 (review) by @obulat

Description

This PR simplifies(?) the load-img action by removing needlessly duplicated code.

Checklist

My pull request has a descriptive title (not a vague title likeUpdate index.md).
My pull request targets the default branch of the repository (main) or a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible errors.
I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

github-actions · 2023-04-20T16:52:57Z

Size Change: 0 B

Total Size: 853 kB

ℹ️ View Unchanged

Filename	Size
`./frontend/.nuxt/dist/client/234.js`	272 B
`./frontend/.nuxt/dist/client/234.modern.js`	277 B
`./frontend/.nuxt/dist/client/235.js`	1.85 kB
`./frontend/.nuxt/dist/client/app.js`	127 kB
`./frontend/.nuxt/dist/client/app.modern.js`	118 kB
`./frontend/.nuxt/dist/client/commons/app.js`	90.3 kB
`./frontend/.nuxt/dist/client/commons/app.modern.js`	78.5 kB
`./frontend/.nuxt/dist/client/components/loading-icon.js`	752 B
`./frontend/.nuxt/dist/client/components/loading-icon.modern.js`	758 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.js`	515 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js`	518 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.js`	5.65 kB
`./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js`	5.49 kB
`./frontend/.nuxt/dist/client/components/v-audio-cell.js`	393 B
`./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js`	396 B
`./frontend/.nuxt/dist/client/components/v-audio-details.js`	2.48 kB
`./frontend/.nuxt/dist/client/components/v-audio-details.modern.js`	1.78 kB
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js`	1.02 kB
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js`	1.02 kB
`./frontend/.nuxt/dist/client/components/v-audio-track.js`	5.6 kB
`./frontend/.nuxt/dist/client/components/v-audio-track.modern.js`	5.54 kB
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js`	543 B
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js`	548 B
`./frontend/.nuxt/dist/client/components/v-bone.js`	689 B
`./frontend/.nuxt/dist/client/components/v-bone.modern.js`	693 B
`./frontend/.nuxt/dist/client/components/v-box-layout.js`	1.28 kB
`./frontend/.nuxt/dist/client/components/v-box-layout.modern.js`	1.28 kB
`./frontend/.nuxt/dist/client/components/v-content-link.js`	1.12 kB
`./frontend/.nuxt/dist/client/components/v-content-link.modern.js`	1.1 kB
`./frontend/.nuxt/dist/client/components/v-content-page.js`	524 B
`./frontend/.nuxt/dist/client/components/v-content-page.modern.js`	528 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.js`	784 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js`	787 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.js`	3.78 kB
`./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js`	3.59 kB
`./frontend/.nuxt/dist/client/components/v-content-report-popover.js`	1.17 kB
`./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js`	4.19 kB
`./frontend/.nuxt/dist/client/components/v-copy-button.js`	3.99 kB
`./frontend/.nuxt/dist/client/components/v-copy-button.modern.js`	4 kB
`./frontend/.nuxt/dist/client/components/v-copy-license.js`	1.71 kB
`./frontend/.nuxt/dist/client/components/v-copy-license.modern.js`	1.69 kB
`./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js`	10 kB
`./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js`	9.99 kB
`./frontend/.nuxt/dist/client/components/v-dmca-notice.js`	753 B
`./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js`	759 B
`./frontend/.nuxt/dist/client/components/v-error-image.js`	1.69 kB
`./frontend/.nuxt/dist/client/components/v-error-image.modern.js`	1.69 kB
`./frontend/.nuxt/dist/client/components/v-error-section.js`	372 B
`./frontend/.nuxt/dist/client/components/v-error-section.modern.js`	376 B
`./frontend/.nuxt/dist/client/components/v-external-search-form.js`	1.86 kB
`./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js`	1.85 kB
`./frontend/.nuxt/dist/client/components/v-external-source-list.js`	844 B
`./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js`	846 B
`./frontend/.nuxt/dist/client/components/v-full-layout.js`	2.13 kB
`./frontend/.nuxt/dist/client/components/v-full-layout.modern.js`	2.11 kB
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.js`	1.61 kB
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js`	1.62 kB
`./frontend/.nuxt/dist/client/components/v-home-gallery.js`	5.27 kB
`./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js`	5.25 kB
`./frontend/.nuxt/dist/client/components/v-homepage-content.js`	1.76 kB
`./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js`	1.73 kB
`./frontend/.nuxt/dist/client/components/v-image-carousel.js`	4.73 kB
`./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js`	4.71 kB
`./frontend/.nuxt/dist/client/components/v-image-cell.js`	1.59 kB
`./frontend/.nuxt/dist/client/components/v-image-cell.modern.js`	1.59 kB
`./frontend/.nuxt/dist/client/components/v-image-details.js`	2.08 kB
`./frontend/.nuxt/dist/client/components/v-image-details.modern.js`	1.41 kB
`./frontend/.nuxt/dist/client/components/v-image-grid.js`	2.67 kB
`./frontend/.nuxt/dist/client/components/v-image-grid.modern.js`	2.55 kB
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.js`	1.24 kB
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js`	1.21 kB
`./frontend/.nuxt/dist/client/components/v-load-more.js`	810 B
`./frontend/.nuxt/dist/client/components/v-load-more.modern.js`	708 B
`./frontend/.nuxt/dist/client/components/v-media-license.js`	829 B
`./frontend/.nuxt/dist/client/components/v-media-license.modern.js`	836 B
`./frontend/.nuxt/dist/client/components/v-media-reuse.js`	2.31 kB
`./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js`	2.28 kB
`./frontend/.nuxt/dist/client/components/v-media-tag.js`	416 B
`./frontend/.nuxt/dist/client/components/v-media-tag.modern.js`	420 B
`./frontend/.nuxt/dist/client/components/v-modal.js`	1.01 kB
`./frontend/.nuxt/dist/client/components/v-modal.modern.js`	996 B
`./frontend/.nuxt/dist/client/components/v-no-results.js`	757 B
`./frontend/.nuxt/dist/client/components/v-no-results.modern.js`	755 B
`./frontend/.nuxt/dist/client/components/v-radio.js`	1.54 kB
`./frontend/.nuxt/dist/client/components/v-radio.modern.js`	1.5 kB
`./frontend/.nuxt/dist/client/components/v-related-audio.js`	1.26 kB
`./frontend/.nuxt/dist/client/components/v-related-audio.modern.js`	1.27 kB
`./frontend/.nuxt/dist/client/components/v-related-images.js`	3.24 kB
`./frontend/.nuxt/dist/client/components/v-related-images.modern.js`	3.13 kB
`./frontend/.nuxt/dist/client/components/v-report-desc-form.js`	977 B
`./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js`	980 B
`./frontend/.nuxt/dist/client/components/v-row-layout.js`	1.67 kB
`./frontend/.nuxt/dist/client/components/v-row-layout.modern.js`	1.68 kB
`./frontend/.nuxt/dist/client/components/v-scroll-button.js`	824 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js`	829 B
`./frontend/.nuxt/dist/client/components/v-search-grid.js`	5.68 kB
`./frontend/.nuxt/dist/client/components/v-search-grid.modern.js`	5.61 kB
`./frontend/.nuxt/dist/client/components/v-search-results-title.js`	599 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js`	605 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.js`	300 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js`	303 B
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js`	1.01 kB
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js`	912 B
`./frontend/.nuxt/dist/client/components/v-snackbar.js`	1.16 kB
`./frontend/.nuxt/dist/client/components/v-snackbar.modern.js`	1.16 kB
`./frontend/.nuxt/dist/client/components/v-sources-table.js`	15.2 kB
`./frontend/.nuxt/dist/client/components/v-sources-table.modern.js`	15.2 kB
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.js`	306 B
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js`	311 B
`./frontend/.nuxt/dist/client/pages/about.js`	1.4 kB
`./frontend/.nuxt/dist/client/pages/about.modern.js`	1.4 kB
`./frontend/.nuxt/dist/client/pages/audio/_id/index.js`	5.66 kB
`./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js`	4.97 kB
`./frontend/.nuxt/dist/client/pages/external-sources.js`	1.56 kB
`./frontend/.nuxt/dist/client/pages/external-sources.modern.js`	1.56 kB
`./frontend/.nuxt/dist/client/pages/feedback.js`	1.34 kB
`./frontend/.nuxt/dist/client/pages/feedback.modern.js`	1.34 kB
`./frontend/.nuxt/dist/client/pages/image/_id/index.js`	6.67 kB
`./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js`	5.85 kB
`./frontend/.nuxt/dist/client/pages/image/_id/report.js`	1.27 kB
`./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js`	4.26 kB
`./frontend/.nuxt/dist/client/pages/index.js`	7.33 kB
`./frontend/.nuxt/dist/client/pages/index.modern.js`	7.28 kB
`./frontend/.nuxt/dist/client/pages/preferences.js`	1.32 kB
`./frontend/.nuxt/dist/client/pages/preferences.modern.js`	1.32 kB
`./frontend/.nuxt/dist/client/pages/privacy.js`	1.01 kB
`./frontend/.nuxt/dist/client/pages/privacy.modern.js`	1.02 kB
`./frontend/.nuxt/dist/client/pages/search-help.js`	1.6 kB
`./frontend/.nuxt/dist/client/pages/search-help.modern.js`	1.58 kB
`./frontend/.nuxt/dist/client/pages/search.js`	2.2 kB
`./frontend/.nuxt/dist/client/pages/search.modern.js`	2.04 kB
`./frontend/.nuxt/dist/client/pages/search/audio.js`	3.61 kB
`./frontend/.nuxt/dist/client/pages/search/audio.modern.js`	3.52 kB
`./frontend/.nuxt/dist/client/pages/search/image.js`	2.84 kB
`./frontend/.nuxt/dist/client/pages/search/image.modern.js`	2.74 kB
`./frontend/.nuxt/dist/client/pages/search/index.js`	443 B
`./frontend/.nuxt/dist/client/pages/search/index.modern.js`	447 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.js`	243 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js`	246 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.js`	266 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js`	270 B
`./frontend/.nuxt/dist/client/pages/search/video.js`	240 B
`./frontend/.nuxt/dist/client/pages/search/video.modern.js`	244 B
`./frontend/.nuxt/dist/client/pages/sources.js`	1.52 kB
`./frontend/.nuxt/dist/client/pages/sources.modern.js`	1.52 kB
`./frontend/.nuxt/dist/client/runtime.js`	2.72 kB
`./frontend/.nuxt/dist/client/runtime.modern.js`	2.72 kB
`./frontend/.nuxt/dist/client/vendors/app.js`	64.1 kB
`./frontend/.nuxt/dist/client/vendors/app.modern.js`	63.3 kB

_{compressed-size-action}

github-actions · 2023-04-20T22:24:32Z

Full-stack documentation: https://docs.openverse.org/_preview/1855

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

…to_all

obulat

Nice solution!

documentation/meta/ci_cd/actions.md

sarayourfriend

Neat! I think it might be slightly (:pinching_hand:) more obscure but only because the previous example was exceedingly straight-forward. This simplifies future maintenance nicely and I think is a fair abstraction over the brute-force action from before :+1:

Co-authored-by: Olga Bulat <obulat@gmail.com>

openverse-bot added this to In progress in Openverse PRs Apr 20, 2023

dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: mgmt Related to repo management and automations labels Apr 20, 2023

github-actions bot added 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: frontend Related to the Nuxt frontend labels Apr 20, 2023

dhruvkb force-pushed the auto_all branch from dbc6386 to 42ca978 Compare April 20, 2023 16:58

Remove all hardcoding from load-img action

f8746a1

dhruvkb force-pushed the auto_all branch from 3a1b9ba to f8746a1 Compare April 20, 2023 22:55

Merge branch 'main' of https://github.com/WordPress/openverse into au…

3b4e54d

…to_all

dhruvkb marked this pull request as ready for review April 21, 2023 04:30

dhruvkb requested a review from a team as a code owner April 21, 2023 04:30

dhruvkb requested review from obulat and sarayourfriend April 21, 2023 04:30

openverse-bot moved this from In progress to Needs review in Openverse PRs Apr 21, 2023

obulat approved these changes Apr 21, 2023

View reviewed changes

documentation/meta/ci_cd/actions.md Outdated Show resolved Hide resolved

documentation/meta/ci_cd/actions.md Outdated Show resolved Hide resolved

sarayourfriend approved these changes Apr 24, 2023

View reviewed changes

Openverse PRs automation moved this from Needs review to Reviewer approved Apr 24, 2023

Make textual improvements suggested by @obulat

beb8eb2

Co-authored-by: Olga Bulat <obulat@gmail.com>

dhruvkb merged commit 1b34383 into main Apr 24, 2023

Openverse PRs automation moved this from Reviewer approved to Merged! Apr 24, 2023

dhruvkb deleted the auto_all branch April 24, 2023 07:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid the need to specify each image individually in `load-img` #1855

Avoid the need to specify each image individually in `load-img` #1855

dhruvkb commented Apr 20, 2023 •

edited

Loading

github-actions bot commented Apr 20, 2023 •

edited

Loading

github-actions bot commented Apr 20, 2023

obulat left a comment

sarayourfriend left a comment •

edited

Loading

Avoid the need to specify each image individually in load-img #1855

Avoid the need to specify each image individually in load-img #1855

Conversation

dhruvkb commented Apr 20, 2023 • edited Loading

Fixes

Description

Checklist

Developer Certificate of Origin

github-actions bot commented Apr 20, 2023 • edited Loading

github-actions bot commented Apr 20, 2023

obulat left a comment

Choose a reason for hiding this comment

sarayourfriend left a comment • edited Loading

Choose a reason for hiding this comment

Avoid the need to specify each image individually in `load-img` #1855

Avoid the need to specify each image individually in `load-img` #1855

dhruvkb commented Apr 20, 2023 •

edited

Loading

github-actions bot commented Apr 20, 2023 •

edited

Loading

sarayourfriend left a comment •

edited

Loading