Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @types/lodash.sortBy from project #1937

Merged
merged 1 commit into from
May 1, 2023
Merged

Remove @types/lodash.sortBy from project #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@
"@testing-library/vue": "^5.8.2",
"@types/express-useragent": "^1.0.2",
"@types/jest": "^26.0.22",
"@types/lodash.sortby": "^4.7.7",
"@types/module-alias": "^2.0.1",
"@types/node": "^17.0.32",
"@types/throttle-debounce": "^5.0.0",
Expand Down
10 changes: 1 addition & 9 deletions pnpm-lock.yaml
View file
Open in desktop
Copy link
Contributor

@obulat obulat May 1, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock file appears to have changes for a lot of unrelated packages, which causes failures in the linting.
When I removed @types/lodash.sortby locally, and ran just node-install, I only saw 4 changes in pnpm-lock.yamlfile. Could you check the version ofpnpmyou are using? It should match the version inpackage.json`'s engines property to generate the correct lock file.

Here's the diff I see in the lock file:

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index e80070fab..8b2b351ea 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -55,7 +55,6 @@ importers:
       '@testing-library/vue': ^5.8.2
       '@types/express-useragent': ^1.0.2
       '@types/jest': ^26.0.22
-      '@types/lodash.sortby': ^4.7.7
       '@types/module-alias': ^2.0.1
       '@types/node': ^17.0.32
       '@types/throttle-debounce': ^5.0.0
@@ -197,7 +196,6 @@ importers:
       '@testing-library/vue': 5.8.2_rhqkolmkwunxzlyyxxsuwaiuri
       '@types/express-useragent': 1.0.2
       '@types/jest': 26.0.24
-      '@types/lodash.sortby': 4.7.7
       '@types/module-alias': 2.0.1
       '@types/node': 17.0.32
       '@types/throttle-debounce': 5.0.0
@@ -6390,12 +6388,6 @@ packages:
     resolution: {integrity: sha512-1YXyYH83h6We1djyoUEqTlVyQtCfJAFXELSKW2ZRtjHD4hQ82CC4lvrv5D0l0FLcKBaiPbXyi3MpMsI9ZRgKsw==}
     dev: true
 
-  /@types/lodash.sortby/4.7.7:
-    resolution: {integrity: sha512-J/4IS+jQopGBrrRetBXDCX0KnSeXJZ0rOTmGAxR9MWGV24YdHxX8IRi9LCGAU9GKWlBov9KRSfQpuup9PReqrw==}
-    dependencies:
-      '@types/lodash': 4.14.182
-    dev: true
-
   /@types/lodash/4.14.182:
     resolution: {integrity: sha512-/THyiqyQAP9AfARo4pF+aCGcyiQ94tX/Is2I7HofNRqoYLgN1PBoOWu2/zTA5zMxzP5EFutMtWtGAFRKUe961Q==}
     dev: true
@@ -11413,7 +11405,7 @@ packages:
     resolution: {integrity: sha512-oWb1Z6mkHIskLzEJ/XWX0srkpkTQ7vaopMQkyaEIoq0fmtFVxOthb8cCxeT+p3ynTdkk/RZwbgG4brR5BeWECw==}
     engines: {node: '>= 4.0'}
     os: [darwin]
-    deprecated: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
+    deprecated: The v1 package contains DANGEROUS / INSECURE binaries. Upgrade to safe fsevents v2
     requiresBuild: true
     dependencies:
       bindings: 1.5.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it passes on local. Let me try after correcting the version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm it once the pipeline finish?

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.