Add additional search view pages to the Nuxt app #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
changed the title
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: +58.4 kB (+6%) 🔍 Total Size: 1.07 MB
ℹ️ View Unchanged
|
obulat
added
🟨 priority: medium
obulat
force-pushed
the
additional_search_views/store-remove-searchby
branch
from
3db4968
to
37f6245
Compare
obulat
force-pushed
the
additional_search_views/store-remove-searchby
branch
2 times, most recently
from
351b8c8
to
eddeee5
Compare
obulat
force-pushed
the
additional_search_views/store-remove-searchby
branch
6 times, most recently
from
033cc95
to
e7a091e
Compare
Base automatically changed from
additional_search_views/store-remove-searchby
to
main
October 23, 2023 11:51
obulat
force-pushed
the
additional_search_views/add-to-store-and-api-service
branch
from
96d3a42
to
e6dd537
Compare
obulat
force-pushed
the
additional_search_views/add-to-store-and-api-service
branch
5 times, most recently
from
b8d488e
to
085c94d
Compare
obulat
changed the base branch from
main
to
additional_search_views/collection_routes
8 tasks
obulat
force-pushed
the
additional_search_views/collection_routes
branch
from
5728670
to
2e7540c
Compare
obulat
force-pushed
the
additional_search_views/add-to-store-and-api-service
branch
from
085c94d
to
8af4d49
Compare
obulat
force-pushed
the
additional_search_views/collection_routes
branch
from
2e7540c
to
b48b865
Compare
obulat
force-pushed
the
additional_search_views/add-to-store-and-api-service
branch
from
a5db8b1
to
cb01698
Compare
fcoveram
requested changes
Dec 1, 2023
There was a problem hiding this comment.
I noticed one odd spacing in VCollectionHeader that can look better with the following two changes:
- Audio results of source, tag, and author in all breakpoints, margin-bottom looks better with
8px. I refer to this area. - Image results of source, tag, and author in all breakpoints, margin-bottom looks better with
16px. I refer to this area.
Pardon the picky territory my suggestions belong to, but QA is the perfect stage for adjustments.
obulat
force-pushed
the
additional_search_views/add-to-store-and-api-service
branch
from
cb01698
to
f1c64be
Compare
Thank you for re-reviewing! I've updated the paddings. I also noticed that the collection pages really didn't render on the server at all, not just because of some local problems. Thank you for flagging that, @fcoveram. I fixed the logic of the collection page parameter validation, and now they do render on the server. |
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
obulat
force-pushed
the
additional_search_views/add-to-store-and-api-service
branch
from
e23b090
to
f1c6cac
Compare
obulat
deleted the
additional_search_views/add-to-store-and-api-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #3136, and will be undrafted after that PR is merged.Fixes
Fixes #2858 by @obulat
Fixes #2774 by @obulat
Description
With this PR, you can view the tag/source/creator collections in the Nuxt app.
To show the collections, we add
_tag.vueand_source.vuepages to bothimageandaudio, with dynamic routes. These pages check the path to make sure that the path has the necessary parameters: tag name for the tag page; an existing source for source/creator pages;/creator/path part and the creator name for the creator pages.In the first iteration, I used a single page with a fully-dynamic path (
/_mediaType/_collection/_.vue) that would then validate themediaType,collectionand the collection parameters. However, because_mediaTypecan accept any string path, it would also match the locale routes such as/ar/non_existent_page), so I split this single page into 4.The collection pages have the collection headers (using
VCollectionHeaderfrom #3365) and either aVAudioCollectionorVImageGrid, as well as the "Load more" button. When you navigate from the collection page to a single result page, you also get the "Back to results" link at the top that goes back to the collection page.This PR adds a
strategyandcollectionParamsprops to thesearchstore. Whenever we set thesearchTerm(which is only available for search, not collection), we reset thestrategytodefaultand nullify thecollectionParams.The API service had to be updated to accept a
slugfor paths like/tag/tag_name,/source/source_name,/source/source_name/creator/creator_name, which are added to the/<mediaType>path.The media store was updated to use the necessary slug from the search store
collectionParams.Testing Instructions
Run the app using
just frontend/run dev. Go to/preferencespage and turn on theadditional_search_viewsfeature flag.The easiest way to land on a collection page is from the single result page. Click on the source, creator or tag buttons - and you will be taken to the corresponding page.
Check that in non-English locales, the links have the correct locale path, and when navigating, the locale is kept.
Check that if you go from a collection page to a single result page, you can go back to the collection page using "Back to results" page.
Check that if you go back to homepage from the collection page, you can search for something.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin