Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renovate config to handle all dependency types and group upgrades #3312

Merged
merged 3 commits into from Nov 6, 2023

Conversation

sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented Nov 3, 2023

Fixes

Fixes #3304 by @sarayourfriend
Closes https://github.com/WordPress/openverse-infrastructure/issues/484 by @sarayourfriend

Description

Updates the existing renovate configuration in the following ways:

  • Match dependabot stack and tech labeling
  • Group dependencies that can be grouped (note: we can continue iterating on this, there are probably lots of good opportunities for this in the frontend especially, I just picked some obvious ones)
  • Update configuration options that were in an older format
  • Add a pre-commit hook to validate the renovate configuration
  • Remove the dependabot configuration (also requires disabling it in the repo settings, I think)

This is one approach we could take. The other is, of course, to continue using dependabot. It has rudimentary support for pnpm and grouped dependencies, both added very recently, but it's a bit more of a chore to configure (lots of repeated labeling rules, for example) and tends to take a very long time to support new features (e.g., pnpm, grouped dependencies, sensible github action matching), if it ever gets them at all.

Testing Instructions

Not entirely sure. I suppose we can run the renovate workflow from this branch and see what happens.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend requested a review from a team as a code owner November 3, 2023 02:17
@github-actions github-actions bot added the 🧱 stack: mgmt Related to repo management and automations label Nov 3, 2023
@openverse-bot openverse-bot added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase labels Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

Size Change: 0 B

Total Size: 946 kB

ℹ️ View Unchanged
Filename Size
./frontend/.nuxt/dist/client/242.js 343 B
./frontend/.nuxt/dist/client/242.modern.js 346 B
./frontend/.nuxt/dist/client/243.js 1.85 kB
./frontend/.nuxt/dist/client/app.js 124 kB
./frontend/.nuxt/dist/client/app.modern.js 115 kB
./frontend/.nuxt/dist/client/commons/app.js 92.5 kB
./frontend/.nuxt/dist/client/commons/app.modern.js 82.6 kB
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/e4094511.js 5.18 kB
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/e4094511.modern.js 5.62 kB
./frontend/.nuxt/dist/client/components/loading-icon.js 732 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 734 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 515 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 519 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.82 kB
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 6.64 kB
./frontend/.nuxt/dist/client/components/v-audio-collection.js 4.51 kB
./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js 4.38 kB
./frontend/.nuxt/dist/client/components/v-audio-control.js 1.5 kB
./frontend/.nuxt/dist/client/components/v-audio-control.modern.js 1.5 kB
./frontend/.nuxt/dist/client/components/v-audio-list.js 1.44 kB
./frontend/.nuxt/dist/client/components/v-audio-list.modern.js 1.41 kB
./frontend/.nuxt/dist/client/components/v-audio-result.js 1.12 kB
./frontend/.nuxt/dist/client/components/v-audio-result.modern.js 1.1 kB
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 958 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 962 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 6.99 kB
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 6.95 kB
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 635 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 640 B
./frontend/.nuxt/dist/client/components/v-bone.js 631 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 636 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.35 kB
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.35 kB
./frontend/.nuxt/dist/client/components/v-collection-header.js 1.3 kB
./frontend/.nuxt/dist/client/components/v-collection-header.modern.js 1.31 kB
./frontend/.nuxt/dist/client/components/v-content-link.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.05 kB
./frontend/.nuxt/dist/client/components/v-content-page.js 530 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 534 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 492 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 497 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.33 kB
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.21 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.81 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.69 kB
./frontend/.nuxt/dist/client/components/v-copy-button.js 3.8 kB
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 3.81 kB
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.34 kB
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.31 kB
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 795 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 801 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.51 kB
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.47 kB
./frontend/.nuxt/dist/client/components/v-error-section.js 5.21 kB
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 4.58 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.js 4.1 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 3.44 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.js 2.63 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 2 kB
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.93 kB
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.92 kB
./frontend/.nuxt/dist/client/components/v-get-media-button.js 622 B
./frontend/.nuxt/dist/client/components/v-get-media-button.modern.js 626 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.53 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.53 kB
./frontend/.nuxt/dist/client/components/v-hide-button.js 575 B
./frontend/.nuxt/dist/client/components/v-hide-button.modern.js 573 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.28 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.26 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.82 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.79 kB
./frontend/.nuxt/dist/client/components/v-image-cell.js 2.24 kB
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 2.23 kB
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.5 kB
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.38 kB
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 641 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 649 B
./frontend/.nuxt/dist/client/components/v-load-more.js 1.18 kB
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.06 kB
./frontend/.nuxt/dist/client/components/v-media-details.js 5.82 kB
./frontend/.nuxt/dist/client/components/v-media-details.modern.js 5.67 kB
./frontend/.nuxt/dist/client/components/v-media-license.js 931 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 940 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 3 kB
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.97 kB
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 420 B
./frontend/.nuxt/dist/client/components/v-media-tags.js 830 B
./frontend/.nuxt/dist/client/components/v-media-tags.modern.js 825 B
./frontend/.nuxt/dist/client/components/v-metadata-value.js 587 B
./frontend/.nuxt/dist/client/components/v-metadata-value.modern.js 593 B
./frontend/.nuxt/dist/client/components/v-metadata.js 1.3 kB
./frontend/.nuxt/dist/client/components/v-metadata.modern.js 1.3 kB
./frontend/.nuxt/dist/client/components/v-modal.js 981 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 973 B
./frontend/.nuxt/dist/client/components/v-no-results.js 2.67 kB
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 2.03 kB
./frontend/.nuxt/dist/client/components/v-radio.js 1 kB
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-related-audio.js 824 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 744 B
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.js 4.51 kB
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.modern.js 4.37 kB
./frontend/.nuxt/dist/client/components/v-related-images.js 804 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 716 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 981 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.72 kB
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.72 kB
./frontend/.nuxt/dist/client/components/v-safety-wall.js 1.44 kB
./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js 1.44 kB
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 892 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 619 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 621 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.js 1.17 kB
./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js 1.17 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 916 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-sources-table.js 15.1 kB
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 15.1 kB
./frontend/.nuxt/dist/client/components/v-tag.js 411 B
./frontend/.nuxt/dist/client/components/v-tag.modern.js 415 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B
./frontend/.nuxt/dist/client/pages/about.js 1.42 kB
./frontend/.nuxt/dist/client/pages/about.modern.js 1.42 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 17.5 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 16.4 kB
./frontend/.nuxt/dist/client/pages/feedback.js 1.36 kB
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.36 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.js 16.1 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 14.8 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.js 4.99 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.74 kB
./frontend/.nuxt/dist/client/pages/index.js 6.38 kB
./frontend/.nuxt/dist/client/pages/index.modern.js 6.35 kB
./frontend/.nuxt/dist/client/pages/preferences.js 1.46 kB
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.46 kB
./frontend/.nuxt/dist/client/pages/privacy.js 1.26 kB
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.26 kB
./frontend/.nuxt/dist/client/pages/search-help.js 1.63 kB
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.62 kB
./frontend/.nuxt/dist/client/pages/search.js 5.78 kB
./frontend/.nuxt/dist/client/pages/search.modern.js 8.13 kB
./frontend/.nuxt/dist/client/pages/search/audio.js 498 B
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 504 B
./frontend/.nuxt/dist/client/pages/search/image.js 453 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 454 B
./frontend/.nuxt/dist/client/pages/search/index.js 316 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 319 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 242 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B
./frontend/.nuxt/dist/client/pages/search/video.js 239 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B
./frontend/.nuxt/dist/client/pages/sensitive-content.js 1.52 kB
./frontend/.nuxt/dist/client/pages/sensitive-content.modern.js 1.53 kB
./frontend/.nuxt/dist/client/pages/sources.js 1.53 kB
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.54 kB
./frontend/.nuxt/dist/client/runtime.js 2.8 kB
./frontend/.nuxt/dist/client/runtime.modern.js 2.81 kB
./frontend/.nuxt/dist/client/vendors/app.js 69.6 kB
./frontend/.nuxt/dist/client/vendors/app.modern.js 69.2 kB

compressed-size-action

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since renovate has had a longer support for groups and pnpm, I agree with going forward with renovate. Thank you for fixing the labelling (renovate PRs didn't have all the necessary labels before) and setting everything up!

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I prefer personally prefer Dependabot over Renovate, Renovate has clear advantages in our case and some features that we would like, so settling on one tool instead of two makes more sense. Thanks for this. The addition of the pre-commit hook is also a great touch, thanks!

I do have some questions and suggestions though.

.github/workflows/renovate.yml Outdated Show resolved Hide resolved
.github/workflows/renovate.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Both dependabot and renovate open dependency update PRs in the monorepo
4 participants