-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency axios to v1 [SECURITY] #3343
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ module.exports = { | |
"^~~/(.*)$": "<rootDir>/$1", | ||
"^vue$": "vue/dist/vue.common.js", | ||
"(.*svg)(\\?inline)$": "<rootDir>/test/unit/test-utils/svgTransform.js", | ||
"^axios$": "axios/dist/node/axios.cjs", | ||
}, | ||
setupFiles: ["<rootDir>/test/unit/setup.js"], | ||
setupFilesAfterEnv: ["<rootDir>/test/unit/setup-after-env.js"], | ||
|
@@ -22,7 +23,7 @@ module.exports = { | |
"^.+\\.svg$": "<rootDir>/test/unit/svg-transform.js", | ||
}, | ||
testPathIgnorePatterns: ["/playwright/", "/storybook/", ".remake"], | ||
collectCoverage: true, | ||
collectCoverage: false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm setting this to false because (a) it's profoundly annoying to deal with locally when running a single test, your console gets flooded with coverage information and (b) we literally do not use this coverage information anywhere at the moment. |
||
coverageDirectory: "<rootDir>/test/unit/coverage", | ||
collectCoverageFrom: [ | ||
"<rootDir>/src/**/*.vue", | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is so....unexpected! I spent a lot of time trying to figure out the fix, but I would never think of looking into this import! Thank you for finding the fix, @sarayourfriend!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all came down to attaching a debugger and noticing that
new AxiosMockAdapter
raised an error in the debug console and then inspecting the imported object and realising "oh... that's Axios!" and then I noticed that the keys here are regexes. I actually did a 🤦 when I realised what a mistake I'd made 😅