Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency prettier to v2.8.8 #3426

Merged
merged 1 commit into from Dec 1, 2023
Merged

Update dependency prettier to v2.8.8 #3426

merged 1 commit into from Dec 1, 2023

Conversation

openverse-bot
Copy link
Collaborator

This PR contains the following updates:

Package Type Update Change
prettier (source) devDependencies patch 2.8.3 -> 2.8.8

Release Notes

prettier/prettier (prettier)

v2.8.8

Compare Source

This version is a republished version of v2.8.7.
A bad version was accidentally published and it can't be unpublished, apologies for the churn.

v2.8.7

Compare Source

diff

Allow multiple decorators on same getter/setter (#​14584 by @​fisker)
// Input
class A {
  @​decorator()
  get foo () {}
  
  @​decorator()
  set foo (value) {}
}

// Prettier 2.8.6
SyntaxError: Decorators cannot be applied to multiple get/set accessors of the same name. (5:3)
  3 |   get foo () {}
  4 |   
> 5 |   @​decorator()
    |   ^^^^^^^^^^^^
  6 |   set foo (value) {}
  7 | }

// Prettier 2.8.7
class A {
  @​decorator()
  get foo() {}

  @​decorator()
  set foo(value) {}
}

v2.8.6

Compare Source

diff

Allow decorators on private members and class expressions (#​14548 by @​fisker)
// Input
class A {
  @​decorator()
  #privateMethod () {}
}

// Prettier 2.8.5
SyntaxError: Decorators are not valid here. (2:3)
  1 | class A {
> 2 |   @​decorator()
    |   ^^^^^^^^^^^^
  3 |   #privateMethod () {}
  4 | }

// Prettier 2.8.6
class A {
  @​decorator()
  #privateMethod() {}
}

v2.8.5

Compare Source

diff

Support TypeScript 5.0 (#​14391 by @​fisker, #​13819 by @​fisker, @​sosukesuzuki)

TypeScript 5.0 introduces two new syntactic features:

  • const modifiers for type parameters
  • export type * declarations
Add missing parentheses for decorator (#​14393 by @​fisker)
// Input
class Person {
  @​(myDecoratorArray[0])
  greet() {}
}

// Prettier 2.8.4
class Person {
  @​myDecoratorArray[0]
  greet() {}
}

// Prettier 2.8.5
class Person {
  @​(myDecoratorArray[0])
  greet() {}
}
Add parentheses for TypeofTypeAnnotation to improve readability (#​14458 by @​fisker)
// Input
type A = (typeof node.children)[];

// Prettier 2.8.4
type A = typeof node.children[];

// Prettier 2.8.5
type A = (typeof node.children)[];
Support max_line_length=off when parsing .editorconfig (#​14516 by @​josephfrazier)

If an .editorconfig file is in your project and it sets max_line_length=off for the file you're formatting,
it will be interpreted as a printWidth of Infinity rather than being ignored
(which previously resulted in the default printWidth of 80 being applied, if not overridden by Prettier-specific configuration).

<!-- Input -->
<div className='HelloWorld' title={`You are visitor number ${ num }`} onMouseOver={onMouseOver}/>

<!-- Prettier 2.8.4 -->
<div
  className="HelloWorld"
  title={`You are visitor number ${num}`}
  onMouseOver={onMouseOver}
/>;

<!-- Prettier 2.8.5 -->
<div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver} />;

v2.8.4

Compare Source

diff

Fix leading comments in mapped types with readonly (#​13427 by @​thorn0, @​sosukesuzuki)
// Input
type Type = {
  // comment
  readonly [key in Foo];
};

// Prettier 2.8.3
type Type = {
  readonly // comment
  [key in Foo];
};

// Prettier 2.8.4
type Type = {
  // comment
  readonly [key in Foo];
};
Group params in opening block statements (#​14067 by @​jamescdavis)

This is a follow-up to #​13930 to establish wrapping consistency between opening block statements and else blocks by
grouping params in opening blocks. This causes params to break to a new line together and not be split across lines
unless the length of params exceeds the print width. This also updates the else block wrapping to behave exactly the
same as opening blocks.

{{! Input }}
{{#block param param param param param param param param param param as |blockParam|}}
  Hello
{{else block param param param param param param param param param param as |blockParam|}}
  There
{{/block}}

{{! Prettier 2.8.3 }}
{{#block
  param
  param
  param
  param
  param
  param
  param
  param
  param
  param
  as |blockParam|
}}
  Hello
{{else block param
param
param
param
param
param
param
param
param
param}}
  There
{{/block}}

{{! Prettier 2.8.4 }}
{{#block
  param param param param param param param param param param
  as |blockParam|
}}
  Hello
{{else block
  param param param param param param param param param param
  as |blockParam|
}}
  There
{{/block}}
Ignore files in .sl/ (#​14206 by @​bolinfest)

In Sapling SCM, .sl/ is the folder where it stores its state, analogous to .git/ in Git. It should be ignored in Prettier like the other SCM folders.

Recognize @satisfies in Closure-style type casts (#​14262 by @​fisker)
// Input
const a = /** @&#8203;satisfies {Record<string, string>} */ ({hello: 1337});
const b = /** @&#8203;type {Record<string, string>} */ ({hello: 1337});

// Prettier 2.8.3
const a = /** @&#8203;satisfies {Record<string, string>} */ { hello: 1337 };
const b = /** @&#8203;type {Record<string, string>} */ ({ hello: 1337 });

// Prettier 2.8.4
const a = /** @&#8203;satisfies {Record<string, string>} */ ({hello: 1337});
const b = /** @&#8203;type {Record<string, string>} */ ({hello: 1337});
Fix parens in inferred function return types with extends (#​14279 by @​fisker)
// Input
type Foo<T> = T extends ((a) => a is infer R extends string) ? R : never;

// Prettier 2.8.3 (First format)
type Foo<T> = T extends (a) => a is infer R extends string ? R : never;

// Prettier 2.8.3 (Second format)
SyntaxError: '?' expected. 

// Prettier 2.8.4
type Foo<T> = T extends ((a) => a is infer R extends string) ? R : never;

Configuration

📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openverse-bot openverse-bot requested a review from a team as a code owner December 1, 2023 01:33
@openverse-bot openverse-bot added dependencies Pull requests that update a dependency file 💻 aspect: code Concerns the software code in the repository 🟨 tech: javascript Involves JavaScript 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Dec 1, 2023
@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023 •
edited

Size Change: 0 B

Total Size: 1.01 MB

ℹ️ View Unchanged
Filename Size
./frontend/.nuxt/dist/client/247.js 343 B
./frontend/.nuxt/dist/client/247.modern.js 346 B
./frontend/.nuxt/dist/client/248.js 1.85 kB
./frontend/.nuxt/dist/client/app.js 132 kB
./frontend/.nuxt/dist/client/app.modern.js 123 kB
./frontend/.nuxt/dist/client/commons/app.js 105 kB
./frontend/.nuxt/dist/client/commons/app.modern.js 87.5 kB
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/4e2d09e1.js 5.18 kB
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/4e2d09e1.modern.js 5.62 kB
./frontend/.nuxt/dist/client/components/loading-icon.js 731 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 734 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 514 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 518 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.85 kB
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 6.68 kB
./frontend/.nuxt/dist/client/components/v-audio-collection.js 4.5 kB
./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js 4.38 kB
./frontend/.nuxt/dist/client/components/v-audio-list.js 1.43 kB
./frontend/.nuxt/dist/client/components/v-audio-list.modern.js 1.41 kB
./frontend/.nuxt/dist/client/components/v-audio-result.js 1.12 kB
./frontend/.nuxt/dist/client/components/v-audio-result.modern.js 1.1 kB
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 957 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 960 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.15 kB
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.1 kB
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 632 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 639 B
./frontend/.nuxt/dist/client/components/v-bone.js 632 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 636 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.16 kB
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.16 kB
./frontend/.nuxt/dist/client/components/v-by-line.js 2.34 kB
./frontend/.nuxt/dist/client/components/v-by-line.modern.js 2.32 kB
./frontend/.nuxt/dist/client/components/v-collection-header.js 1.49 kB
./frontend/.nuxt/dist/client/components/v-collection-header.modern.js 1.5 kB
./frontend/.nuxt/dist/client/components/v-content-link.js 1.06 kB
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.06 kB
./frontend/.nuxt/dist/client/components/v-content-page.js 531 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 536 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 493 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 497 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.35 kB
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.23 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.82 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.69 kB
./frontend/.nuxt/dist/client/components/v-copy-button.js 3.8 kB
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 3.81 kB
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.34 kB
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.31 kB
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-license-tab-panel/components/v-media-reuse/pages/image/_id/index.js 3.8 kB
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-license-tab-panel/components/v-media-reuse/pages/image/_id/index.modern.js 3.81 kB
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 795 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 801 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.51 kB
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.47 kB
./frontend/.nuxt/dist/client/components/v-error-section.js 5.22 kB
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 4.58 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.js 4.1 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 3.44 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.js 2.63 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 1.99 kB
./frontend/.nuxt/dist/client/components/v-full-layout.js 3.76 kB
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 3.74 kB
./frontend/.nuxt/dist/client/components/v-get-media-button.js 623 B
./frontend/.nuxt/dist/client/components/v-get-media-button.modern.js 628 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.55 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.55 kB
./frontend/.nuxt/dist/client/components/v-hide-button.js 594 B
./frontend/.nuxt/dist/client/components/v-hide-button.modern.js 592 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.28 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.26 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.82 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.79 kB
./frontend/.nuxt/dist/client/components/v-image-cell.js 2.24 kB
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 2.23 kB
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.53 kB
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.41 kB
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 641 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 648 B
./frontend/.nuxt/dist/client/components/v-load-more.js 1.18 kB
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-media-details.js 5.88 kB
./frontend/.nuxt/dist/client/components/v-media-details.modern.js 5.73 kB
./frontend/.nuxt/dist/client/components/v-media-info.js 2.56 kB
./frontend/.nuxt/dist/client/components/v-media-info.modern.js 2.54 kB
./frontend/.nuxt/dist/client/components/v-media-license.js 931 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 938 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 3 kB
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.97 kB
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 420 B
./frontend/.nuxt/dist/client/components/v-media-tags.js 885 B
./frontend/.nuxt/dist/client/components/v-media-tags.modern.js 883 B
./frontend/.nuxt/dist/client/components/v-metadata-value.js 604 B
./frontend/.nuxt/dist/client/components/v-metadata-value.modern.js 609 B
./frontend/.nuxt/dist/client/components/v-metadata.js 1.32 kB
./frontend/.nuxt/dist/client/components/v-metadata.modern.js 1.32 kB
./frontend/.nuxt/dist/client/components/v-modal.js 982 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 973 B
./frontend/.nuxt/dist/client/components/v-no-results.js 2.67 kB
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 2.03 kB
./frontend/.nuxt/dist/client/components/v-old-icon-button.js 853 B
./frontend/.nuxt/dist/client/components/v-old-icon-button.modern.js 846 B
./frontend/.nuxt/dist/client/components/v-radio.js 1.02 kB
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.02 kB
./frontend/.nuxt/dist/client/components/v-related-audio.js 824 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 745 B
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.js 4.5 kB
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.modern.js 4.37 kB
./frontend/.nuxt/dist/client/components/v-related-images.js 802 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 718 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 996 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 999 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 2.05 kB
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 2.05 kB
./frontend/.nuxt/dist/client/components/v-safety-wall.js 1.45 kB
./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js 1.46 kB
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 891 B
./frontend/.nuxt/dist/client/components/v-scroller.js 596 B
./frontend/.nuxt/dist/client/components/v-scroller.modern.js 592 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 616 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 621 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.js 1.18 kB
./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js 1.18 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.02 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 916 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.06 kB
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-source-creator-button.js 547 B
./frontend/.nuxt/dist/client/components/v-source-creator-button.modern.js 550 B
./frontend/.nuxt/dist/client/components/v-sources-table.js 15.2 kB
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 15.2 kB
./frontend/.nuxt/dist/client/components/v-tag.js 411 B
./frontend/.nuxt/dist/client/components/v-tag.modern.js 416 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 307 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B
./frontend/.nuxt/dist/client/pages/about.js 1.42 kB
./frontend/.nuxt/dist/client/pages/about.modern.js 1.42 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 21 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 19.7 kB
./frontend/.nuxt/dist/client/pages/feedback.js 1.36 kB
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.36 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.js 18.1 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 16.7 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.js 5 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.75 kB
./frontend/.nuxt/dist/client/pages/index.js 6.41 kB
./frontend/.nuxt/dist/client/pages/index.modern.js 6.35 kB
./frontend/.nuxt/dist/client/pages/preferences.js 1.46 kB
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.46 kB
./frontend/.nuxt/dist/client/pages/privacy.js 1.26 kB
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.26 kB
./frontend/.nuxt/dist/client/pages/search-help.js 1.08 kB
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.08 kB
./frontend/.nuxt/dist/client/pages/search.js 5.82 kB
./frontend/.nuxt/dist/client/pages/search.modern.js 8.13 kB
./frontend/.nuxt/dist/client/pages/search/audio.js 499 B
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 501 B
./frontend/.nuxt/dist/client/pages/search/image.js 452 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 454 B
./frontend/.nuxt/dist/client/pages/search/index.js 316 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 320 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 242 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 243 B
./frontend/.nuxt/dist/client/pages/sensitive-content.js 1.52 kB
./frontend/.nuxt/dist/client/pages/sensitive-content.modern.js 1.53 kB
./frontend/.nuxt/dist/client/pages/sources.js 1.53 kB
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.54 kB
./frontend/.nuxt/dist/client/runtime.js 2.87 kB
./frontend/.nuxt/dist/client/runtime.modern.js 2.87 kB
./frontend/.nuxt/dist/client/vendors/app.js 69 kB
./frontend/.nuxt/dist/client/vendors/app.modern.js 68.5 kB

compressed-size-action

dhruvkb
dhruvkb approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier is sneaking up to a v4 release now, I got notified of an RC release today. And while it would be nice to be able to upgrade to that, I'll settle for a +5 patch bump.

@dhruvkb dhruvkb merged commit d3d91cc into main Dec 1, 2023
42 checks passed
@dhruvkb dhruvkb deleted the gha-renovateprettier-2.x branch December 1, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obulat obulat obulat approved these changes

@dhruvkb dhruvkb dhruvkb approved these changes

@AetherUnbound AetherUnbound Awaiting requested review from AetherUnbound AetherUnbound is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend 🟨 tech: javascript Involves JavaScript
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openverse-bot @obulat @dhruvkb