Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename catalog requirements files to match Renovate pattern #3521

Merged
merged 1 commit into from Dec 15, 2023

Conversation

AetherUnbound
Copy link
Contributor

Description

I recently noticed that Airflow v2.7.3 was released last month, but we hadn't received a Renovate PR to update it. They were added in #3465 but should have been updated since then.

I added Renovate debug logging using the following and ran the Renovate workflow on that branch:

diff --git a/.github/workflows/renovate.yml b/.github/workflows/renovate.yml
index bd98989f6..4543bcd5f 100644
--- a/.github/workflows/renovate.yml
+++ b/.github/workflows/renovate.yml
@@ -68,6 +68,7 @@ jobs:
         env:
           # This enables the cache -- if this is set, it's not necessary to add it to renovate.json.
           RENOVATE_REPOSITORY_CACHE: ${{ github.event.inputs.repoCache || 'enabled' }}
+          LOG_LEVEL: "debug"
 
       # Compression helps performance in the upload step!
       - name: Compress renovate cache

While looking through the lines, I saw this:

2023-12-12T00:31:34.1520637Z DEBUG: Using file match: (^|/)[\w-]*requirements(-\w+)?\.(txt|pip)$ for manager pip_requirements (repository=WordPress/openverse)
...
2023-12-12T00:31:34.7391009Z DEBUG: Matched 1 file(s) for manager pip_requirements: archive/requirements.txt (repository=WordPress/openverse)

Note that the pattern Renovate is expecting is requirements- not requirements_! Additionally, the catalog requirements are missing from the pip_requirements that Renovate is looking for. So I think the underscore was preventing Renovate from finding the catalog's requirements.

This PR changes the files to match the appropriate, expected pattern.

Testing Instructions

I think we'll have to merge this and then run the Renovate workflow and see if it helps!

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested review from a team as code owners December 13, 2023 20:37
@AetherUnbound AetherUnbound added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Dec 13, 2023
@AetherUnbound AetherUnbound merged commit 85f1491 into main Dec 15, 2023
69 checks passed
@AetherUnbound AetherUnbound deleted the fix/catalog-requirements-rename branch December 15, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants