New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render per-repo pull request template #356
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ba27308
Move templates into template folder
AetherUnbound 4d95953
Add pull request templates
AetherUnbound 82f618e
Add render-github to justfile, make local pre-commit dynamic
AetherUnbound ec6808b
Update sync configuration for pull request template
AetherUnbound 62d58d7
Update README
AetherUnbound File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
.pre-commit-config.frontend.yaml.jinja → ...es/.pre-commit-config.frontend.yaml.jinja
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{% extends 'templates/.pre-commit-config.yaml.jinja' %} | ||
|
||
{% block note %} | ||
{{ super() }} | ||
# - https://github.com/WordPress/openverse/blob/main/templates/.pre-commit-config.local.yaml.jinja | ||
{%- endblock %} | ||
|
||
{% block repos_bottom %} | ||
{# This comment adds a blank line. #} | ||
- repo: local | ||
hooks: | ||
{% set renders = ["precommit", "prettier", "github"] %} | ||
{% for render in renders %} | ||
- id: render-{{ render }} | ||
name: render-{{ render }} | ||
entry: bash -c 'just render-{{ render }}' | ||
language: system | ||
pass_filenames: false | ||
{% endfor %} | ||
{% endblock %} |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{% extends 'templates/PULL_REQUEST_TEMPLATE.md.jinja' %} | ||
|
||
{% block additional_checks %} | ||
- [ ] I ran the DAG documentation generator (if applicable). | ||
{% endblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
## Fixes | ||
|
||
<!-- If PR doesn't fully resolve the issue, replace 'Fixes' below with 'Related to'. --> | ||
<!-- If there is no issue being resolved, please consider opening one before creating this pull request. --> | ||
|
||
Fixes #[issue number] by @[issue author] | ||
|
||
## Description | ||
|
||
<!-- Concisely describe what the pull request does. --> | ||
<!-- Add screenshots, videos, or other media to show the problem and the solution when appropriate. --> | ||
|
||
## Testing Instructions | ||
|
||
<!-- Give steps for the reviewer to verify that this PR fixes the problem; or delete this section entirely. --> | ||
|
||
{% block additional_sections %} | ||
{% endblock -%} | ||
|
||
## Checklist | ||
|
||
<!-- Replace the [ ] with [x] to check the boxes. --> | ||
|
||
- [ ] My pull request has a descriptive title (not a vague title like | ||
`Update index.md`). | ||
- [ ] My pull request targets the _default_ branch of the repository (`main`) or | ||
a parent feature branch. | ||
- [ ] My commit messages follow [best practices][best_practices]. | ||
- [ ] My code follows the established code style of the repository. | ||
- [ ] I added or updated tests for the changes I made (if applicable). | ||
- [ ] I added or updated documentation (if applicable). | ||
- [ ] I tried running the project locally and verified that there are no visible | ||
errors. | ||
{% block additional_checks %} | ||
{% endblock %} | ||
|
||
[best_practices]: | ||
https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines | ||
|
||
## Developer Certificate of Origin | ||
|
||
<!-- You must read and understand the following attestation. --> | ||
|
||
<details> | ||
<summary>Developer Certificate of Origin</summary> | ||
|
||
``` | ||
Developer Certificate of Origin | ||
Version 1.1 | ||
|
||
Copyright (C) 2004, 2006 The Linux Foundation and its contributors. | ||
1 Letterman Drive | ||
Suite D4700 | ||
San Francisco, CA, 94129 | ||
|
||
Everyone is permitted to copy and distribute verbatim copies of this | ||
license document, but changing it is not allowed. | ||
|
||
|
||
Developer's Certificate of Origin 1.1 | ||
|
||
By making a contribution to this project, I certify that: | ||
|
||
(a) The contribution was created in whole or in part by me and I | ||
have the right to submit it under the open source license | ||
indicated in the file; or | ||
|
||
(b) The contribution is based upon previous work that, to the best | ||
of my knowledge, is covered under an appropriate open source | ||
license and I have the right under that license to submit that | ||
work with modifications, whether created in whole or in part | ||
by me, under the same open source license (unless I am | ||
permitted to submit under a different license), as indicated | ||
in the file; or | ||
|
||
(c) The contribution was provided directly to me by some other | ||
person who certified (a), (b) or (c) and I have not modified | ||
it. | ||
|
||
(d) I understand and agree that this project and the contribution | ||
are public and that a record of the contribution (including all | ||
personal information I submit with it, including my sign-off) is | ||
maintained indefinitely and may be redistributed consistent with | ||
this project or the open source license(s) involved. | ||
``` | ||
|
||
</details> |
4 changes: 2 additions & 2 deletions
4
prettier.config.frontend.js.jinja → templates/prettier.config.frontend.js.jinja
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an amazing use of Jinja, I love it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we could make even the list itself dynamic so we didn't have to update it, but alas that seems more challenging than it's worth 😅