Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PRs fix for PR Board automation #3649

Merged
merged 41 commits into from Jan 17, 2024

Conversation

The5cheduler
Copy link
Contributor

@The5cheduler The5cheduler commented Jan 10, 2024

Fixes

Fixes #3467 by @AetherUnbound

Description

  • Included additional check for case where PRs that both have changes requested and are drafted should be in the drafted column of the PR board.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

The5cheduler and others added 30 commits December 21, 2023 23:43
@The5cheduler The5cheduler requested a review from a team as a code owner January 10, 2024 02:21
@openverse-bot openverse-bot added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🏷 status: label work required Needs proper labelling before it can be worked on labels Jan 10, 2024
@The5cheduler The5cheduler marked this pull request as draft January 10, 2024 02:35
@The5cheduler The5cheduler marked this pull request as ready for review January 10, 2024 02:35
@The5cheduler The5cheduler marked this pull request as draft January 10, 2024 02:46
@The5cheduler The5cheduler changed the title PR Board Fix for Draft PRs Draft PRs fix for PR Board automation Jan 10, 2024
@The5cheduler The5cheduler marked this pull request as ready for review January 10, 2024 02:53
@The5cheduler
Copy link
Contributor Author

add label: 🧱 stack: mgmt

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change, although correct in terms of the diff, has been made in the wrong place. It was supposed to be on line 85.

@The5cheduler
Copy link
Contributor Author

Applied requested changes with ec3305a

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this contribution @The5cheduler! We will have to wait for a second approval, feel free to contribute on another issue in the meantime.

@dhruvkb dhruvkb added 🧱 stack: mgmt Related to repo management and automations and removed 🏷 status: label work required Needs proper labelling before it can be worked on 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 15, 2024
@openverse-bot
Copy link
Collaborator

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@AetherUnbound
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was ready for review 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2.

@The5cheduler, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the fix 😄

@AetherUnbound AetherUnbound merged commit f8b1170 into WordPress:main Jan 17, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PRs that both have changes requested and are drafted should be in the drafted column of the PR board
5 participants