Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rawpixel image URLs for ingestion #3669

Merged

Conversation

rawpixel-vincent
Copy link
Contributor

@rawpixel-vincent rawpixel-vincent commented Jan 16, 2024

Fixes

Related to #3573 by @fcoveram

Description

  • Update the image url preset used to avoid watermark images
  • add a thumbnail url to the metadata
  • select png preset when relevant.

Important: if the webp format is problematic, full_size_option can be replaced by image_1000 (its similar to image_social_landscape but doesn't imply orientation is a factor)

Ran the ingestion_server tests and catalog test locally.

Testing Instructions

Test the rawpixel image source are displayed properly and without watermark after ingestion.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
read and approved

@rawpixel-vincent rawpixel-vincent requested a review from a team as a code owner January 16, 2024 07:09
@openverse-bot openverse-bot added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🏷 status: label work required Needs proper labelling before it can be worked on labels Jan 16, 2024
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: catalog Related to the catalog and Airflow DAGs and removed 🏷 status: label work required Needs proper labelling before it can be worked on 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 16, 2024
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @rawpixel-vincent! 😄 I have a few notes, the largest being which field we set for the thumbnail value. Let me know if any of these could use further explanations!

catalog/dags/providers/provider_api_scripts/rawpixel.py Outdated Show resolved Hide resolved
catalog/dags/providers/provider_api_scripts/rawpixel.py Outdated Show resolved Hide resolved
catalog/dags/providers/provider_api_scripts/rawpixel.py Outdated Show resolved Hide resolved
catalog/dags/providers/provider_api_scripts/rawpixel.py Outdated Show resolved Hide resolved
@AetherUnbound AetherUnbound changed the title update ingestion server rawpixel image urls Update Rawpixel image URLs for ingestion Jan 17, 2024
@openverse-bot
Copy link
Collaborator

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@krysal
@stacimc
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was ready for review 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2.

@rawpixel-vincent, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

@AetherUnbound AetherUnbound marked this pull request as draft January 23, 2024 00:28
@AetherUnbound
Copy link
Contributor

Drafting until feedback can be addressed!

@rawpixel-vincent rawpixel-vincent marked this pull request as ready for review January 23, 2024 20:32
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great, thanks so much @rawpixel-vincent! I was able to run this locally and confirm that the primary & thumbnail URLs don't have the watermark 🚀 Can't thank you enough for your assist with the domain knowledge on the Rawpixel front on this one 😄

Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests perfectly for me -- thanks @rawpixel-vincent! 🚀

@stacimc stacimc merged commit 991c4bf into WordPress:main Jan 24, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants