Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions running on deprecated Node v16 #3801

Merged
merged 8 commits into from Feb 19, 2024
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Feb 16, 2024

Description

This PR updates the actions that are still running on Node 16 and raising deprecation warnings. They have been updated to their latest versions.

In the case of now-unmaintained action extractions/setup-just, I have switched to a different maintained one.

One action peaceiris/actions-gh-pages has not been updated to Node v20 yet (PR peaceiris/actions-gh-pages#1067 merged, no release since). There is a possibility to drop it altogether, in favour of official actions https://github.com/actions/upload-pages-artifact and https://github.com/actions/deploy-pages but those that can be a separate issue.

Testing Instructions

  1. Check that CI continues to run.
  2. Refer to the breaking changes for the action from their docs and ensure we're not affected by them.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: mgmt Related to repo management and automations 🔧 tech: github actions Involves Github Actions labels Feb 16, 2024
@dhruvkb dhruvkb requested a review from a team as a code owner February 16, 2024 05:04
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding all of the updatable actions!

.github/actions/setup-env/action.yml Show resolved Hide resolved
.github/actions/setup-env/action.yml Show resolved Hide resolved
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhruvkb dhruvkb merged commit 68ffb8d into main Feb 19, 2024
76 checks passed
@dhruvkb dhruvkb deleted the upgrade_gha_node_20 branch February 19, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations 🔧 tech: github actions Involves Github Actions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants