Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Europeana timeout #3826

Merged
merged 1 commit into from Feb 26, 2024
Merged

Extend Europeana timeout #3826

merged 1 commit into from Feb 26, 2024

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Feb 23, 2024

Fixes

The Europeana DAG continues to occasionally time out in production.

Description

Following #3453 which extended the timeout to 1 week, this PR extends it even further to 12 days.

The Europeana DAG runs on a daily schedule and ingests all the records that were last updated on the ingestion day. It completes in <20 minutes with a small number of records for the majority of runs, but every few weeks there is an ingestion day with a much larger amount of data. These runs can take a very long time to complete, because the scheduled daily runs that queued up in the meantime will likely all complete very quickly as soon as it finishes, allowing the dag to "catch up".

Since 1 week has not been enough time at least twice now in production, we should try extending it even further.

Testing Instructions

just up, run the Europeana DAG locally and inspect the Details view for the pull_data task to ensure that the execution_timeout is set appropriately.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Feb 23, 2024
@stacimc stacimc self-assigned this Feb 23, 2024
@stacimc stacimc requested a review from a team as a code owner February 23, 2024 17:36
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stacimc stacimc merged commit 8615579 into main Feb 26, 2024
65 checks passed
@stacimc stacimc deleted the fix/extend-europeana-timeout branch February 26, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants