Combine related media component using VMediaCollection.vue

[obulat]

Fixes

Extracted from #3785 to make it easier to review.
Fixes #3832 by @obulat

Note: 428 lines of the 987 added lines are from "tapes" (saved API responses used for tests)

Description

We currently have two separate components for related images and related audio that are basically duplicating each other. This PR combines the 2 related components.

A bigger change is the new VMediaCollection component (originally introduced in #3785, but split from it to make reviewing simpler).

This component handles displaying the header, grid skeleton if fetching or the media collection if fetched, and the footer with load more button and the external search form, if necessary.

To simplify this component, I used slots for header and footer, and created wrapper components (similar to the audio templates) for the related, search and collection results. This PR contains the VMediaCollection and the VRelatedMedia.vue wrapper component. It does not use footer because the related media does not have load more button (or the external search form).

This PR renames the "old" components for audio and image grid to minimize the number of changes (VImageGrid and VAudioList are "old", and VImageCollection and VAudioCollection are the new ones).

There's also a tiny unrelated change: the loading skeleton for image single result is now centered (using mx-auto class).

Testing Instructions

Select an audio result and click on one of the related audios. You should see the SELECT_RESULT event with the relatedTo set correctly. The related images/audio should look correct.

Look at the single result pages. The related media section should look and behave correctly.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[zackkrida]

I'll review this in the next day! Somehow didn't see that I was on it.

[obulat]

This is the old VAudioCollection.vue component.

[zackkrida]

Does this impact our line number matching in the .pot files? I don't think so, because it's the full strings, but want to confirm.

[obulat]

I don't know, will need to check. Would the line numbers make the strings fuzzy in GlotPress?

[zackkrida]

This is really nice work. The type improvements and tests look good too. I left a minor suggestion and a design question.

[openverse-bot]

Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR:

@dhruvkb
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend¹ days, this PR was ready for review 5 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)².

@obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

1. Specifically, Saturday and Sunday. ↩

2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩