Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Free Music Archive to external sources in the frontend #3834

Merged
merged 4 commits into from Feb 29, 2024

Conversation

alt-shreya
Copy link
Contributor

@alt-shreya alt-shreya commented Feb 27, 2024

Fixes

Fixes #2486 by @zackkrida

Description

Added Free Music Archive to the inbuilt External sources frontend functionality.

Screenshot from 2024-02-27 18-03-06

image_screenshot_fma_test
Screenshot from 2024-02-27 18-03-39

Testing Instructions

Optional:

  1. Run just frontend/run dev
  2. Open an audio search page
  3. Scroll down to the "External sources" button

The popup should contain "Free Music Archive", and clicking on it should give the results of the query on Openverse website.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@alt-shreya alt-shreya requested a review from a team as a code owner February 27, 2024 12:39
@openverse-bot openverse-bot added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Feb 27, 2024
@alt-shreya
Copy link
Contributor Author

@AetherUnbound tagging you here as you assigned this issue to me ✨

@obulat obulat added 🧱 stack: frontend Related to the Nuxt frontend and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Feb 27, 2024
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alt-shreya,
This is a great start, thank you for the screenshots in the PR description!
The tests are failing because the snapshots are now outdated. You need to update the snapshots, here are the instructions on how to do that: https://docs.openverse.org/frontend/guides/test.html#updating-snapshots

Comment here if you need any help, I'll be happy to do so or to update the snapshots for you if needed.

@krysal krysal changed the title feat(interface): added FMA to external sources frontend Add Free Music Archive to external sources in the frontend Feb 27, 2024
@obulat
Copy link
Contributor

obulat commented Feb 28, 2024

@alt-shreya, I am going to draft this PR while the changes are being made to prevent Openverse bot from pinging for reviews. Please undraft it when you add the snapshots.

@obulat obulat marked this pull request as draft February 28, 2024 03:59
@alt-shreya
Copy link
Contributor Author

Hi @alt-shreya, This is a great start, thank you for the screenshots in the PR description! The tests are failing because the snapshots are now outdated. You need to update the snapshots, here are the instructions on how to do that: https://docs.openverse.org/frontend/guides/test.html#updating-snapshots

Comment here if you need any help, I'll be happy to do so or to update the snapshots for you if needed.

@obulat I've updated the snapshots in my most recent commits. I only updated for visual-regression as these were the tests that were failing. Please let me know if you have more feedback!

@alt-shreya alt-shreya marked this pull request as ready for review February 28, 2024 07:42
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution! 😄 One nit for a newline that doesn't appear necessary.

frontend/src/utils/get-additional-sources.ts Outdated Show resolved Hide resolved
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution, @alt-shreya!

@alt-shreya
Copy link
Contributor Author

@obulat @AetherUnbound
Thanks for all your help! I had a great time contributing! Looking forward to making more PRs 😄 🎉

@obulat obulat merged commit 8438dd8 into WordPress:main Feb 29, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Free Music Archive to the "External Sources" frontend feature
4 participants