New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Free Music Archive to external sources in the frontend #3834
Add Free Music Archive to external sources in the frontend #3834
Conversation
@AetherUnbound tagging you here as you assigned this issue to me ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alt-shreya,
This is a great start, thank you for the screenshots in the PR description!
The tests are failing because the snapshots are now outdated. You need to update the snapshots, here are the instructions on how to do that: https://docs.openverse.org/frontend/guides/test.html#updating-snapshots
Comment here if you need any help, I'll be happy to do so or to update the snapshots for you if needed.
external sources
frontend
@alt-shreya, I am going to draft this PR while the changes are being made to prevent Openverse bot from pinging for reviews. Please undraft it when you add the snapshots. |
@obulat I've updated the snapshots in my most recent commits. I only updated for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the contribution! 😄 One nit for a newline that doesn't appear necessary.
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for your contribution, @alt-shreya!
@obulat @AetherUnbound |
Fixes
Fixes #2486 by @zackkrida
Description
Added
Free Music Archive
to the inbuiltExternal sources
frontend functionality.Testing Instructions
Optional:
just frontend/run dev
The popup should contain "Free Music Archive", and clicking on it should give the results of the query on Openverse website.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin