Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename verbose plural "mature" to "sensitive" in API admin #3837

Merged
merged 1 commit into from Feb 28, 2024

Conversation

AetherUnbound
Copy link
Contributor

@AetherUnbound AetherUnbound commented Feb 28, 2024

Description

Quick follow up to #3769, when looking in staging I realized that there was one instance of "mature" that I hadn't updated 馃槄

This is a tiny PR to update the last reference!

There's a migration attached to it but it's "in-Django" only:

$ j api/dj sqlmigrate api 0057
BEGIN;
--
-- Change Meta options on sensitiveaudio
--
-- (no-op)
COMMIT;

Testing Instructions

  1. Build and run the app locally
  2. Visit http://localhost:50270/admin/api/sensitiveaudio/ and ensure that the text on the side bar says "Sensitive audio" and note "Mature audio"

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner February 28, 2024 05:40
@AetherUnbound AetherUnbound added 馃煣 priority: high Stalls work on the project or its dependents 馃洜 goal: fix Bug fix 馃搫 aspect: text Concerns the textual material in the repository 馃П stack: api Related to the Django API labels Feb 28, 2024
Copy link

This PR has migrations. Please rebase it before merging to ensure that conflicting migrations are not introduced.

@github-actions github-actions bot added the migrations Modifications to Django migrations label Feb 28, 2024
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thankfully no DB migration.

@AetherUnbound AetherUnbound merged commit 95049ec into main Feb 28, 2024
68 of 69 checks passed
@AetherUnbound AetherUnbound deleted the hotfix/mature-code-api branch February 28, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃搫 aspect: text Concerns the textual material in the repository 馃洜 goal: fix Bug fix migrations Modifications to Django migrations 馃煣 priority: high Stalls work on the project or its dependents 馃П stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants