Fix flaky content report form test #3880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2020 by @sarayourfriend
Description
This test was previously known to be flaky: #2020. The flake involved an offset of 1-2 pixels in both the content and width of the popover (the locator produced with
getReportButton
). To fix this, the test now uses a screenshot of the entire page, rather than the isolated report element, and an increased maxDiffPixel ratio.It also removes a redundant snapshot of the close button focus state, which wasn't working as intended anyway.
Testing Instructions
Check that CI passes and that the changes and their documentation make sense.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin