Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically apply the project proposal and IP labels to PRs #3982

Merged
merged 2 commits into from Mar 29, 2024

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Mar 28, 2024

Description

This PR adds the glob pattern for implementation plans to our auto-labeller so that PRs that add (or modify) implementation plans automatically get applied the "馃Л project: implementation plan" label.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 馃煩 priority: low Low priority and doesn't need to be rushed 馃捇 aspect: code Concerns the software code in the repository 馃О goal: internal improvement Improvement that benefits maintainers, not users 馃П stack: mgmt Related to repo management and automations labels Mar 28, 2024
@dhruvkb dhruvkb requested a review from a team as a code owner March 28, 2024 08:27
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion!

.github/auto-label.json Show resolved Hide resolved
@dhruvkb dhruvkb changed the title Automatically apply the IP label to PRs that modify implementation plans Automatically apply the project proposal and IP labels to PRs Mar 29, 2024
@dhruvkb dhruvkb merged commit 5bfab8b into main Mar 29, 2024
39 checks passed
@dhruvkb dhruvkb deleted the auto_label_ip branch March 29, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃捇 aspect: code Concerns the software code in the repository 馃О goal: internal improvement Improvement that benefits maintainers, not users 馃煩 priority: low Low priority and doesn't need to be rushed 馃П stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants