Fix date range sent to Slack from reingestion workflows

[BaileyMcKelway]

Fixes

Fixes #3964 by @stacimc

Description

The create_report_load_completion function has been modified to conditionally add date range parameters to the Slack notification based on whether the workflow is a reingestion process. This prevents misleading date range information from being included in reingestion notifications.

Testing Instructions

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[dhruvkb]

These keyword-arguments are being passed to the

openverse/catalog/dags/common/loader/reporting.py

Line 105 in 5041280

def report_completion(

Python function. That function will also need some changes to remove the date-information line from the actual message that gets sent to Slack.

[BaileyMcKelway]

These keyword-arguments are being passed to the

openverse/catalog/dags/common/loader/reporting.py

Line 105 in 5041280

def report_completion(

Python function. That function will also need some changes to remove the date-information line from the actual message that gets sent to Slack.

Alright changes are made in the new commit.

[BaileyMcKelway]

How can I check the Slack message locally? I ran Airflow locally and triggered the DAGs but is it possible to trigger the Slack message?

[dhruvkb]

@BaileyMcKelway since the Slack webhooks are configured for our internal workspace, it wouldn't be possible for you to trigger the message and see it for real. But you can make up a pseudo-preview of the message like this.

1. See the text logged by the send_message function.
2. Go to Slack's Block Kit Builder. You will need to sign in with your "Making WordPress" Slack credentials.
3. Replace <enter your message here> with the log message and paste it into the Block builder's right pane.

   {
     "blocks": [
       {
          "type": "section",
          "text": {
            "type": "mrkdwn",
            "text": "<enter your message here>"
          }
       }
     ]
   }

Here's an example.

This should give you an approximate idea of what the message will look like.

[AetherUnbound]

Thanks again for your contribution @BaileyMcKelway! I have a few idiomatic suggestions for the code, and one requested change regarding the message text. I greatly appreciate the new test!

[BaileyMcKelway]

Thanks again for your contribution @BaileyMcKelway! I have a few idiomatic suggestions for the code, and one requested change regarding the message text. I greatly appreciate the new test!

Alrighty committed suggested changes. 🫡

[AetherUnbound]

Tested this locally, and this is what the sample message looked like:

Seems great!

[BaileyMcKelway]

Tested this locally, and this is what the sample message looked like:

Seems great!

Do I need to ping somebody else to review?

Referring to this, "At least 2 approving reviews are required to merge this pull request."

[dhruvkb]

We'll I've already reviewed it and it LGTM, so I should approve it too. Thanks for the contribution @BaileyMcKelway!