Move ESLint plugin inside packages/js

.codespell/ignore_lines.txt

@@ -17,6 +17,6 @@
         "Identificatie Titel(s):  Allegorie op kunstenaar Francesco Mazzoli, "
         "bekend als Parmigianino"
 
-;; packages/eslint-plugin/configs/vue.ts
+;; packages/js/eslint-plugin/configs/vue.ts
 ;; `te` gets matched with `the` and others
 const i18nDestructureRules = ["t", "tc", "te", "td", "d", "n"].map(

.github/CODEOWNERS

@@ -10,7 +10,7 @@ load_sample_data.sh @WordPress/openverse-api
 pyproject.toml      @WordPress/openverse-api
 
 frontend/           @WordPress/openverse-frontend
-packages/           @WordPress/openverse-frontend
+packages/js/        @WordPress/openverse-frontend
 .eslintignore       @WordPress/openverse-frontend
 .eslintrc.js        @WordPress/openverse-frontend
 .npmrc              @WordPress/openverse-frontend

.github/filters.yml

@@ -23,15 +23,15 @@ ingestion_server:
   - load_sample_data.sh
 frontend:
   - frontend/**
-  - packages/**
+  - packages/js/**
   - package.json
   - pnpm-lock.yaml
   - pnpm-workspace.yaml
   - tsconfig.base.json
   - .npmrc
   - .pnpmfile.cjs
-packages:
-  - packages/**
+js_packages:
+  - packages/js/**
   - package.json
   - pnpm-lock.yaml
   - pnpm-workspace.yaml

.github/renovate.json

@@ -47,7 +47,7 @@
       "addLabels": ["🟨 tech: javascript"]
     },
     {
-      "matchFileNames": ["{frontend,packages}/**"],
+      "matchFileNames": ["{frontend,packages/js}/**"],
       "addLabels": ["🧱 stack: frontend"]
     },
     {
@@ -78,7 +78,7 @@
     },
     {
       "groupName": "@openverse/eslint-plugin",
-      "matchFileNames": ["packages/eslint-plugin/**"]
+      "matchFileNames": ["packages/js/eslint-plugin/**"]
     },
     {
       "groupName": "tailwind",

.github/workflows/ci_cd.yml

@@ -44,7 +44,7 @@ jobs:
       frontend: ${{ contains(fromJson(steps.paths-filter.outputs.changes), 'frontend') }}
       documentation: ${{ contains(fromJson(steps.paths-filter.outputs.changes), 'documentation') }}
       ci_cd: ${{ contains(fromJson(steps.paths-filter.outputs.changes), 'ci_cd') }}
-      packages: ${{ contains(fromJson(steps.paths-filter.outputs.changes), 'packages') }}
+      js_packages: ${{ contains(fromJson(steps.paths-filter.outputs.changes), 'js_packages') }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -600,10 +600,10 @@ jobs:
       - name: Pass
         run: echo 'Playwright tests are skipped because frontend is unchanged.'
 
-  package-checks:
-    name: Run checks for packages/*
+  js-package-checks:
+    name: Run checks for JS packages/*
     if: |
-      needs.get-changes.outputs.packages == 'true'
+      needs.get-changes.outputs.js_packages == 'true'
     runs-on: ubuntu-latest
     needs:
       - get-changes
@@ -630,19 +630,19 @@ jobs:
           setup_python: false
           install_recipe: node-install
 
-      - name: Run packages checks
-        run: pnpm --filter ./packages/* run --aggregate-output ${{ matrix.script }}
+      - name: Run JS packages checks
+        run: pnpm --filter ./packages/js/* run --aggregate-output ${{ matrix.script }}
 
-  # This job runs when `package-checks` doesn't and always passes, thus allowing
-  # PRs to meet the required checks criteria and be merged.
-  bypass-package-checks:
-    name: Run checks for packages/*
+  # This job runs when `js-package-checks` doesn't and always passes, thus
+  # allowing PRs to meet the required checks criteria and be merged.
+  bypass-js-package-checks:
+    name: Run checks for JS packages/*
     if: |
       !cancelled() &&
-      needs.package-checks.result == 'skipped'
+      needs.js-package-checks.result == 'skipped'
     runs-on: ubuntu-latest
     needs:
-      - package-checks
+      - js-package-checks
     strategy:
       fail-fast: false
       matrix:
@@ -652,7 +652,7 @@ jobs:
 
     steps:
       - name: Pass
-        run: echo 'Checks for packages are skipped because packages are unchanged.'
+        run: echo 'Checks for JS packages are skipped because they are unchanged.'
 
   playwright:
     name: Run Playwright tests

.pre-commit-config.yaml

@@ -118,22 +118,22 @@ repos:
     hooks:
       - id: types
         name: types
-        files: ^(frontend|packages)/.*$
+        files: ^(frontend|packages/js)/.*$
         entry: bash -c 'pnpm run -r types'
         language: system
         pass_filenames: false
 
       - id: eslint
         name: eslint
-        files: (frontend|automations|packages).*?\.(js|ts|vue|json5|json)$
+        files: (frontend|automations|packages/js).*?\.(js|ts|vue|json5|json)$
         "types": [file] # ESLint only accepts [javascript] by default.
         language: system
         pass_filenames: false
         entry: bash -c 'pnpm run eslint --fix'
 
       - id: test:unit
         name: test:unit
-        files: ^(frontend|packages)/.*$
+        files: ^(frontend|packages/js)/.*$
         entry: bash -c 'pnpm run -r test:unit'
         language: system
         pass_filenames: false

documentation/meta/ci_cd/jobs/packages.md

@@ -1,8 +1,8 @@
 # Packages jobs
 
-## `package-checks`
+## `js-package-checks`
 
-Runs a matrix for various checks of workspace packages in the `packages`
+Runs a matrix for various checks of workspace packages in the `packages/js`
 directory using the following `package.json` scripts.
 
 | Name        | Script      |
@@ -11,9 +11,9 @@ directory using the following `package.json` scripts.
 | `unit_test` | `test:unit` |
 
 ```{note}
-Not all packages in `packages` necessarily need to define both or any of these scripts.
-`pnpm run -r` will safely ignore packages that do not define a given script and just
-run it for the ones that do.
+Not all packages in `packages/js/` necessarily need to define both or any of
+these scripts. `pnpm run -r` will safely ignore packages that do not define a
+given script and just run it for the ones that do.
 ```
 
 Since this is a required check for a matrix job, it has a bypass counterpart.

documentation/packages/index.md

@@ -36,10 +36,10 @@ The easiest way to create a new package is to copy an existing one and modify
 the details to match the needs. To create a new `@openverse/license-parsing`
 package, for example, we would do the following:
 
-1. Copy `packages/eslint-plugin` to `packages/license-parsing`
-2. Update `packages/license-parsing/package.json` to remove unneeded
+1. Copy `packages/js/eslint-plugin` to `packages/js/license-parsing`
+2. Update `packages/js/license-parsing/package.json` to remove unneeded
    dependencies and update the package name
-3. Delete the code in `packages/license-parsing/src`, update any relevant
+3. Delete the code in `packages/js/license-parsing/src`, update any relevant
    configuration (`babel.config.js`, etc) and write the code for the new package
    🎉
 

package.json

@@ -9,9 +9,9 @@
   },
   "author": "Openverse <openverse@wordpress.org>",
   "scripts": {
-    "postinstall": "pnpm --filter './packages/*' run build",
+    "postinstall": "pnpm --filter './packages/js/*' run build",
     "preeslint": "pnpm --filter '@openverse/eslint-plugin' run build",
-    "eslint": "eslint --ext .js,.ts,.vue,.json,.json5 --ignore-path .gitignore --ignore-path .eslintignore --max-warnings=0 frontend automations/js packages .pnpmfile.cjs .eslintrc.js prettier.config.js tsconfig.base.json"
+    "eslint": "eslint --ext .js,.ts,.vue,.json,.json5 --ignore-path .gitignore --ignore-path .eslintignore --max-warnings=0 frontend automations/js packages/js .pnpmfile.cjs .eslintrc.js prettier.config.js tsconfig.base.json"
   },
   "packageManager": "pnpm@8.15.7",
   "engines": {

packages/eslint-plugin/src/configs/import.ts → packages/js/eslint-plugin/src/configs/import.ts

@@ -82,11 +82,11 @@ export = {
       },
     },
     {
-      files: ["packages/**"],
+      files: ["packages/js/**"],
       settings: {
         "import/resolver": {
           typescript: {
-            project: "packages/*/tsconfig.json",
+            project: "packages/js/*/tsconfig.json",
           },
         },
       },

packages/eslint-plugin/src/configs/index.ts → packages/js/eslint-plugin/src/configs/index.ts

@@ -43,7 +43,7 @@ export const project: TSESLint.Linter.Config = {
     },
     {
       env: { jest: true },
-      files: ["packages/**/*/test", "frontend/test/unit/**"],
+      files: ["packages/js/**/*/test", "frontend/test/unit/**"],
       plugins: ["jest"],
       extends: ["plugin:jest/recommended"],
       rules: {

packages/eslint-plugin/src/utils/rule-creator.ts → packages/js/eslint-plugin/src/utils/rule-creator.ts

@@ -2,7 +2,7 @@ import { ESLintUtils } from "@typescript-eslint/utils"
 
 export const OpenverseRule = ESLintUtils.RuleCreator(
   (ruleName) =>
-    `https://docs.openverse.org/packages/eslint_plugin/${ruleName.replaceAll(
+    `https://docs.openverse.org/packages/js/eslint_plugin/${ruleName.replaceAll(
       "-",
       "_"
     )}.html`

packages/eslint-plugin/tsconfig.json → packages/js/eslint-plugin/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.base.json",
+  "extends": "../../../tsconfig.base.json",
   "compilerOptions": {
     "module": "NodeNext",
     "noEmit": true,

pnpm-workspace.yaml

@@ -1,4 +1,4 @@
 packages:
   - automations/js/
   - frontend/
-  - packages/*
+  - packages/js/*

tsconfig.base.json

@@ -13,7 +13,7 @@
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
     "paths": {
-      "@openverse/*": ["./packages/*/src"]
+      "@openverse/*": ["./packages/js/*/src"]
     },
 
     /**