Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DAG run link, explanation of missing failures to agg failure report #4180

Merged
merged 1 commit into from Apr 23, 2024

Conversation

AetherUnbound
Copy link
Contributor

Description

This PR makes two changes to the reingestion aggregate failures Slack message:

image

Testing Instructions

I made the following change locally, then added the SLACK_MESSAGE_OVERRIDE Variable with the value true:

diff --git a/catalog/dags/providers/provider_api_scripts/phylopic.py b/catalog/dags/providers/provider_api_scripts/phylopic.py
index 5a1f53d77..3c67e15f0 100644
--- a/catalog/dags/providers/provider_api_scripts/phylopic.py
+++ b/catalog/dags/providers/provider_api_scripts/phylopic.py
@@ -94,6 +94,7 @@ class PhylopicDataIngester(ProviderDataIngester):
         return self.current_page < self.total_pages
 
     def get_batch_data(self, response_json):
+        # raise ValueError("Whoops!")
         return response_json.get("_embedded", {}).get("items", [])
 
     def _get_creator(self, data: dict) -> tuple[str | None, str | None]:
diff --git a/catalog/dags/providers/provider_reingestion_workflows.py b/catalog/dags/providers/provider_reingestion_workflows.py
index 58f3c97d0..23b80344c 100644
--- a/catalog/dags/providers/provider_reingestion_workflows.py
+++ b/catalog/dags/providers/provider_reingestion_workflows.py
@@ -83,9 +83,6 @@ PROVIDER_REINGESTION_WORKFLOWS = [
         max_active_tasks=2,
         pull_timeout=timedelta(hours=12),
         daily_list_length=6,
-        one_month_list_length=9,
-        three_month_list_length=18,
-        six_month_list_length=30,
     ),
     ProviderReingestionWorkflow(
         # 64 total reingestion days

This then produced a Slack message which shows both the new DAG run link and the new truncation explanation. The links will fail because the port is set to 8080 (for internal docker mapping), changing the URL to use port 9090 makes the link work correctly.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound added the 🟨 priority: medium Not blocking but should be addressed soon label Apr 22, 2024
@AetherUnbound AetherUnbound requested a review from a team as a code owner April 22, 2024 20:39
@AetherUnbound AetherUnbound added 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🔧 tech: airflow Involves Apache Airflow 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Apr 22, 2024
Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Great improvement!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice :shipit:

@AetherUnbound AetherUnbound merged commit 975d42a into main Apr 23, 2024
70 checks passed
@AetherUnbound AetherUnbound deleted the fix/reingestion-failure-agg-message branch April 23, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs 🔧 tech: airflow Involves Apache Airflow
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants