Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete field from docker-compose.yml #4200

Merged
merged 2 commits into from Apr 26, 2024
Merged

Conversation

krysal
Copy link
Member

@krysal krysal commented Apr 24, 2024

Description

Every time a just command involving docker is run, you get a warning:

CleanShot 2024-04-24 at 18 39 42@2x

According to documentation, it can be safely removed.

This PR also removes some unused imports from the file defining API URLs.

Testing Instructions

Compare this branch with main looking at the output of the just api/up, for example.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: api Related to the Django API 🧱 stack: mgmt Related to repo management and automations labels Apr 24, 2024
@krysal krysal requested review from a team as code owners April 24, 2024 22:45
@krysal krysal requested review from obulat and dhruvkb April 24, 2024 22:45
@AetherUnbound
Copy link
Contributor

This is related to #4046, and it seems there may be some other work that's necessary in order to close that issue.

@sarayourfriend
Copy link
Contributor

@AetherUnbound Can you specify what additional work is needed based on the issue? If this PR works in CI and locally, then I think we're good to go. There was some speculation that the compose file version changes might affect our existing usage, but it seems like they didn't 🤔 we were only using forward compatible features?

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI passing is a good indication we're good to go here. Things work for me locally too, as far as I can tell!

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because CI passes.

Comment on lines -8 to -9
from django.conf import settings
from django.conf.urls.static import static
Copy link
Member

@dhruvkb dhruvkb Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, unused imports are not caught in __init__.py. Good catch, @krysal!

@sarayourfriend sarayourfriend merged commit 25b9137 into main Apr 26, 2024
74 checks passed
@sarayourfriend sarayourfriend deleted the fix/docker_warning branch April 26, 2024 06:38
@AetherUnbound
Copy link
Contributor

There was some speculation that the compose file version changes might affect our existing usage, but it seems like they didn't 🤔

This was my only concern, based on the language you used in the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API 🧱 stack: mgmt Related to repo management and automations
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants