Remove env from Airflow alerts, improve ES alert username & icon #4652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4613 by @sarayourfriend
Description
This PR adjusts the default messaging pattern in Airflow to remove the environment from the username (see the linked issue for rationale).
It also changes the username and icon for Elasticsearch healthcheck related alerts to make the cluster in question more prominent, and the alert itself distinct from other Airflow alerts. Here's a screenshot of the new alert:
Testing Instructions
ov c
andov i
SLACK_MESSAGE_OVERRIDE
with the valuetrue
staging_elasticsearch_cluster_healthcheck
orproduction_elasticsearch_cluster_healthcheck
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin