Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive content filter #824

Closed
wants to merge 3 commits into from

Conversation

anton202
Copy link
Contributor

@anton202 anton202 commented Mar 2, 2023

Fixes

Related to #636 by @panchovm

Description

This PR creates a Toggle switch and a new sensitive content filter
senetive-filter

Testing Instructions

to activate the filter go to localhost:8443/preferences and check toggle_sensitive_content

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@anton202 anton202 requested a review from a team as a code owner March 2, 2023 11:57
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Mar 2, 2023
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Mar 2, 2023
@zackkrida
Copy link
Member

@anton202 this will be an excellent place to implement whatever is finally decided on in #791. What you have is super close what will likely be the final designs. I'm going to mark this as blocked until that is done and I'll let you know when the final designs are ready!

@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 🖼️ aspect: design Concerns related to design ⛔ status: blocked Blocked & therefore, not ready for work 🧱 stack: frontend Related to the Nuxt frontend and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 7, 2023
@AetherUnbound
Copy link
Contributor

I'm not sure why Staci and I were chosen as reviewers 😅 I'll swap us out for more frontend-focused people 🙂

@AetherUnbound AetherUnbound requested review from a team, zackkrida and dhruvkb and removed request for a team, AetherUnbound and stacimc March 14, 2023 01:00
@openverse-bot
Copy link
Collaborator

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@zackkrida
@dhruvkb
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was updated 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2.

@anton202, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

@zackkrida zackkrida marked this pull request as draft April 5, 2023 17:55
@openverse-bot openverse-bot moved this from Needs review to In progress in Openverse PRs Apr 5, 2023
@zackkrida
Copy link
Member

Hi @anton202, I just wanted to check in. We're really close to resolving the design discussion in #791, and I've moved this PR to a draft until then. Thanks for your patience.

@sarayourfriend
Copy link
Contributor

@anton202 I'm going to close this PR for now. We've finished the discussion in the design issue that Zack linked above, however we'll want to write an implementation plan before working on the designs as they are somewhat different from what we had before. If you're interested in working on implementing this after the plan is finished, let me know and I'll make sure to ping you when the issues are ready.

Openverse PRs automation moved this from In progress to Closed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖼️ aspect: design Concerns related to design 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend ⛔ status: blocked Blocked & therefore, not ready for work
Projects
No open projects
Openverse PRs
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

5 participants