Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add production API deployment action #840

Merged
merged 1 commit into from Mar 8, 2023

Conversation

AetherUnbound
Copy link
Contributor

Description

Follow up to https://github.com/WordPress/openverse-infrastructure/pull/398, this PR adds the production deployment action for the API!

Testing Instructions

Merge and try it out 馃檪

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner March 3, 2023 23:33
@AetherUnbound AetherUnbound added the 馃煥 priority: medium Not blocking but should be addressed soon label Mar 3, 2023
@AetherUnbound AetherUnbound added 馃専 goal: addition Addition of new feature 馃 aspect: dx Concerns developers' experience with the codebase 馃П stack: api Related to the Django API labels Mar 3, 2023
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Mar 3, 2023
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Full-stack documentation: Ready

https://WordPress.github.io/openverse/_preview/840

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@zackkrida zackkrida requested review from sarayourfriend and dhruvkb and removed request for krysal and dhruvkb March 8, 2023 16:30
Openverse PRs automation moved this from Needs review to Reviewer approved Mar 8, 2023
@zackkrida
Copy link
Member

zackkrida commented Mar 8, 2023

@sarayourfriend if you have the time I've added you as a potential reviewer here, just for the sake of making this update visible to you as someone who architected much of this project. No worries if you can't! Dhruv got it.

@AetherUnbound AetherUnbound merged commit a81042b into main Mar 8, 2023
46 checks passed
Openverse PRs automation moved this from Reviewer approved to Merged! Mar 8, 2023
@AetherUnbound AetherUnbound deleted the feature/api-prod-deployment-action branch March 8, 2023 18:53
dhruvkb pushed a commit that referenced this pull request Apr 14, 2023
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃 aspect: dx Concerns developers' experience with the codebase 馃専 goal: addition Addition of new feature 馃煥 priority: medium Not blocking but should be addressed soon 馃П stack: api Related to the Django API
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants