Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement admin pointer to indicate to the user they need to activate the new standalone plugins #653

Closed
Tracked by #656
felixarntz opened this issue Feb 16, 2023 · 3 comments
Closed
Tracked by #656

Implement admin pointer to indicate to the user they need to activate the new standalone plugins #653

felixarntz opened this issue Feb 16, 2023 · 3 comments
Assignees
@mukeshpanchal27
Labels
Creating standalone plugins Infrastructure Issues for the overall performance plugin infrastructure Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Infrastructure
Milestone
PL Plugin 2.8.0

Comments

@felixarntz
Copy link
Member

Feature Description

Follow-up to #652: For sites where the conditions in #652 apply, an admin pointer should also show up to ensure the user sees that they need to do something on the PL settings screen (specifically, install/activate the standalone plugins for the modules that they used to have active).

Requirements

  • TODO.
@felixarntz felixarntz added Infrastructure Issues for the overall performance plugin infrastructure Creating standalone plugins labels Feb 16, 2023
@felixarntz felixarntz self-assigned this Feb 16, 2023
@felixarntz felixarntz added this to Backlog in Infrastructure via automation Feb 16, 2023
@felixarntz felixarntz mentioned this issue Feb 16, 2023
Closed
@felixarntz felixarntz added the [Type] Enhancement A suggestion for improvement of an existing feature label Feb 16, 2023
@felixarntz felixarntz mentioned this issue Feb 16, 2023
Open
35 tasks
@felixarntz felixarntz added this to the 3.0.0 milestone Feb 16, 2023
@felixarntz felixarntz added the Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only label Jul 19, 2023
@felixarntz felixarntz mentioned this issue Nov 21, 2023
Closed
@mukeshpanchal27
Copy link
Member

Hello @felixarntz, since we included the admin notice in issue #652, do we still need to incorporate the Admin pointer?

Please let me know if I've missed anything here. Additionally, the requirements are absent in the issue description. Could you please provide those details? cc. @eclarke1 @joemcgill

@mukeshpanchal27 mukeshpanchal27 moved this from Backlog to To do in Infrastructure Dec 12, 2023
@felixarntz
Copy link
Member Author

@mukeshpanchal27 See my PR feedback in #899 (comment), we shouldn't ever add a general admin notice to all of WP Admin.

For bringing attention to the action the user needs to do on our screen, an admin pointer is more suitable, so I'd say we should implement it in this issue as planned.

This was referenced Dec 12, 2023
Closed
Merged
@mukeshpanchal27 mukeshpanchal27 moved this from To do to In progress in Infrastructure Dec 18, 2023
@mukeshpanchal27 mukeshpanchal27 mentioned this issue Dec 18, 2023
Merged
3 tasks
@mukeshpanchal27 mukeshpanchal27 moved this from In progress to Review in Infrastructure Dec 18, 2023
@felixarntz
Copy link
Member Author

Fixed via #910 and #915

Infrastructure automation moved this from Review to Done Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
Creating standalone plugins Infrastructure Issues for the overall performance plugin infrastructure Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Infrastructure
Done
Milestone
PL Plugin 2.8.0
Development

No branches or pull requests
2 participants
@felixarntz @mukeshpanchal27