Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge feature/creating-standalone-plugins feature branch #902

Merged
merged 178 commits into from Jan 8, 2024
Merged

Merge feature/creating-standalone-plugins feature branch #902

merged 178 commits into from Jan 8, 2024

Conversation

felixarntz
Copy link
Member

@felixarntz felixarntz commented Dec 12, 2023 •
edited

Summary

Fixes #901

This is just a merge PR. All code in this PR has been previously reviewed and approved.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

10upsimon and others added 30 commits July 20, 2023 11:29
@10upsimon
Merge branch 'trunk' of github.com:WordPress/performance into trunk
b3be9f3
@10upsimon
Merge branch 'trunk' of github.com:WordPress/performance into trunk
00b04a5
@10upsimon
Merge branch 'trunk' of github.com:WordPress/performance into trunk
5e557cc
@10upsimon
Merge branch 'trunk' into enhancement/652-migration-ui-from-old-modul…
6c86689 
…es-to-standalone-plugins
@10upsimon
Merge remote-tracking branch 'origin/trunk' into enhancement/652-migr…
72dd81f 
…ation-ui-from-old-modules-to-standalone-plugins
@10upsimon
WIP add plugin_manager.js POC file to showcase endpoint logic is work…
61829fa 
…ing.
@10upsimon
Add build command for admin JS assets.
9f12f4c
@10upsimon
WIP Defined class structure and classes (POC) for handling standalone…
7b40985 
… plugin managment UI and REST endpoints.
@10upsimon
Define autoload class mapping in composer.
622fd8b
@10upsimon
Instantiate plugin manager class and associated rest class instantes …
0b3d019 
…in applicable load files, enqueue necessary scripts for settings screen.
@10upsimon
Update gitignore so that built script dir is ignored.
918c176
@10upsimon
Update namespace.
084cd26
@10upsimon
WIP standalone plugins
3823c3f
@10upsimon
Merge branch 'trunk' of github.com:WordPress/performance into trunk
4f997a5
@10upsimon
Merge branch 'trunk' into enhancement-v2/652-migration-ui-from-old-mo…
b07fa1b 
…dules-to-standalone-plugins
@10upsimon
Add Plugin_Manager class to handle rendering/UI for plugin cards, and…
88fc7e3 
… plugin install actions.
@10upsimon
Fix kses error.
f79613d
@10upsimon
Ongoing translation tweaks. Redundant code and method removal.
139f32c
@10upsimon
Remove no longer needed REST controller files.
6dc97e1
@10upsimon
Remove redundant REST use statements following removal of rest contro…
2037e8e 
…ller files.
@10upsimon
Update package lock file.
2b176db
@10upsimon
Removed redundant admin asset compilation script in package json.
7f969b3
@10upsimon
Remove redundant src folder.
4da908b
@10upsimon
Removed update class from update plugin button to avoid ajax update p…
50a0d2f 
…rocess triggering UI and JS errors.
@10upsimon
Merge branch 'trunk' of github.com:WordPress/performance into trunk
7b6b21c
@10upsimon
Merge branch 'trunk' into feature/creating-standalone-plugins
b3c6e5b
@10upsimon
Merge pull request #865 from WordPress/trunk
c77bc57 
Update `feature/creating-standalone-plugins` With Latest Trunk
@10upsimon
Merge branch 'feature/creating-standalone-plugins' of github.com:Word…
f6460a6 
…Press/performance into feature/creating-standalone-plugins
@10upsimon
Merge branch 'feature/creating-standalone-plugins' into issue/651-pl-…
49faaf2 
…settings-screen-manage-standalone-plugins
@10upsimon
Clean up action hook names.
bbcaf9e
mukeshpanchal27 and others added 15 commits December 19, 2023 11:17
@mukeshpanchal27
Fix PHP Documentation Standards
461d741
@mukeshpanchal27
Move inline script in to JS
d6dbecc
@felixarntz
Merge pull request #912 from WordPress/fix/followup-changes
30f1679 
Follow-up: Minor changes for creating standalone plugins
@felixarntz
Minor update to return doc.
6d4cd74
@felixarntz
Merge pull request #910 from WordPress/fix/653-add-module-migration-p…
28b8905 
…ointer

Implement admin pointer to indicate to the user they need to activate the new standalone plugins
@mukeshpanchal27
un-dismiss the migration pointer
50b637f
@mukeshpanchal27
improve code
f56d804
@felixarntz
Rename variable.
17f773a
@felixarntz
Merge pull request #915 from WordPress/fix/un-dismiss-pointer
5a4cf83 
Implement "un-dismiss" migration pointer functionality when the user activates a module
@mukeshpanchal27
Revise migration pointer un-dismissal to work for all admins
9d1a435
@mukeshpanchal27
Address slow query feedbacks
f4fcc72
@mukeshpanchal27 @felixarntz
Apply suggestions from code review
0dc84fa 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@mukeshpanchal27
Update function name
c580b15
@swissspidy
Merge pull request #917 from WordPress/fix/revise-migration-pointer
8e377d5
@felixarntz
Merge branch 'trunk' into feature/creating-standalone-plugins
a776953
@felixarntz
Copy link
Member Author

The moment has come, it looks like we're ready to merge the feature branch into trunk, in preparation for the upcoming 2.8.0 release which will thus launch the plugin management and module migration functionality. 🎉

This PR probably doesn't need a full review as it's all code that has already been reviewed and approved, but another glance over review may still be helpful. Once merged, we'll still have a full week that we can use for testing and fixing any potential bugs we find.

Note this PR intentionally has no milestone as that's used for the changelog. Instead, the 4 main PRs that are part of this (#864, #899, #910, #915) are milestoned with 2.8.0 and will be used for the respective changelog messages.

@felixarntz felixarntz marked this pull request as ready for review January 4, 2024 21:23
@mukeshpanchal27
Copy link
Member

@felixarntz, while testing the changes, I came across a potential enhancement that requires attention. To address this, I've opened PR #920.

@felixarntz felixarntz merged commit 4001794 into trunk Jan 8, 2024
11 checks passed
@felixarntz felixarntz deleted the feature/creating-standalone-plugins branch February 26, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

@swissspidy swissspidy Awaiting requested review from swissspidy

@joemcgill joemcgill Awaiting requested review from joemcgill

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge feature/creating-standalone-plugins feature branch into trunk
5 participants
@felixarntz @mukeshpanchal27 @westonruter @10upsimon @swissspidy