Reset admin pointer dismissal for module migration when the user activates a module #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshpanchal27
added
[Type] Enhancement
swissspidy
approved these changes
Dec 20, 2023
felixarntz
requested changes
Dec 20, 2023
There was a problem hiding this comment.
Thank you for the PR @mukeshpanchal27. Looks close, I have one performance thing worth addressing here and another functional concern that could however also be addressed in a separate follow up PR.
felixarntz
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
@mukeshpanchal27 LGTM, but let's follow up on the user conversation, potentially with a follow up PR once we have agreed on the approach.
felixarntz
merged commit 5a4cf83
into
feature/creating-standalone-plugins
7 checks passed
3 tasks
felixarntz
added
the
Infrastructure
felixarntz
removed
the
no milestone
felixarntz
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #910 (comment)
The PR introduced the capability to "un-dismiss" a pointer when a user activates a module. Within the code, the
perflab_run_module_activation_deactivationfunction is utilized, triggered upon saving settings for the Performance Lab.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.