Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated code to display plugin settings link in the features screen and fix responsive layout for mobile #1208
Updated code to display plugin settings link in the features screen and fix responsive layout for mobile #1208
Changes from 22 commits
d11dfee
c7cd3d1
3fd724e
e88f109
e7dbfa6
95642a3
2da8c22
c197b9f
1501ebc
bc55f7a
d024264
8067df4
b4b73ca
3a3d733
2473091
91b1f73
0fe54ec
eecfad1
08b83aa
606c4e3
18a71cc
0cf11f5
b946a4d
3e6b9d4
ea00ad5
af3b5a9
c7ba02c
893e91b
57e0f8e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
$show_settings_link
variable needed? Couldn't this code be put right up above where$show_settings_link = true;
is currently?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter yes the variable is needed as the suggestion to move the Settings links to the last in the list made the "Learn more" link consistent over all the plugin cards.
I set a variable in the if condition checking if the plugin is active, and at the end of the else condition, added the Settings link into the action links array.