Add a simple admin page for background jobs #506
Conversation
There was a problem hiding this comment.
@eugene-manuilov Leaving some early thoughts here, for reference.
I renamed this branch to experiment/* because we shouldn't use feature/* anymore except for actual feature branches.
| */ | ||
|
|
||
| $screen = get_current_screen(); | ||
| $screen->post_type = 'post'; |
There was a problem hiding this comment.
Is this needed? Preferably the taxonomy shouldn't be attached to any specific post type.
| @@ -59,7 +64,7 @@ function perflab_register_background_job_taxonomy() { | |||
| * `wp_set_object_terms` which do not check if there is relationship | |||
| * between object and taxonomy. | |||
| */ | |||
| register_taxonomy( 'background_job', array(), $args ); | |||
| register_taxonomy( 'background_job', array( 'post' ), $args ); | |||
There was a problem hiding this comment.
See my other comment. This feels a bit like a hack? It shouldn't be tied to the post post type.
| function perflab_register_background_jobs_page() { | ||
| add_management_page( | ||
| __( 'Background Jobs', 'performance-lab' ), | ||
| __( 'Background Jobs', 'performance-lab' ), | ||
| 'manage_categories', | ||
| 'background-jobs', | ||
| 'perflab_render_background_jobs_page' | ||
| ); | ||
| } | ||
| add_action( 'admin_menu', 'perflab_register_background_jobs_page' ); |
There was a problem hiding this comment.
I wonder if instead of a custom page we could rather use the regular edit-tags.php?taxonomy=background_job screen, even if we added the link to it in a custom place in the admin menu.
|
@eugene-manuilov Reassigning to you to review Felix's initial feedback. |
|
@eugene-manuilov Apologies, looks like this has been closed. |
Summary
Fixes #491
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.