New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WebP handling when editing images based on WordPress 6.3 change #796
Conversation
@joemcgill Turns out there is a breaking change in WordPress 6.3 😞 Not sure if it's worth fixing since it's a very low-level function, but in any case I opened https://core.trac.wordpress.org/ticket/59040 for consideration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @felixarntz for the PR. Left one question.
With the changes we have to update WebP Uploads plugin.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Good catch! I've prepared the WebP Uploads standalone plugin for the update in 65b5fdc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @felixarntz for the changes. LGTM!
@joemcgill Could you please take a look so we can merge this PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates look good to me. I've not gotten a chance to review the breaking change in WP yet, but thanks for reporting it.
Summary
Unit tests currently fail in
trunk
, based on the 6.3 release from yesterday. There are two problems that lead to those failures:This PR brings parity with those changes:
thumbnail
andnothumb
only when editing thumbnails separately is enabled (if using WP 6.3 or greater, per the new filter).Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.