Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Node to v16 #800

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Bump Node to v16 #800

merged 2 commits into from
Aug 10, 2023

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Aug 10, 2023 •
edited

Summary

Also includes some minor updates of dependencies, npm audit fix changes, and a general lock file update to lockfileVersion 2.

Failing PHP tests are handled by #796

Fixes #797

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@swissspidy
Bump Node to v16
5c3255a 
Also includes some minor updates of dependencies and a general lock file update to `lockfileVersion` 2.
@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Aug 10, 2023
mukeshpanchal27
mukeshpanchal27 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swissspidy for the PR. LGTM!

felixarntz
felixarntz approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swissspidy!

@swissspidy swissspidy merged commit 47f6e44 into trunk Aug 10, 2023
8 of 9 checks passed
@swissspidy swissspidy deleted the chore/update-node-deps branch August 10, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Node / NPM versions for development following WP core change
3 participants
@swissspidy @felixarntz @mukeshpanchal27